Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate library warning when building realm2json #7710

Merged
merged 1 commit into from
May 20, 2024

Conversation

michael-wb
Copy link
Contributor

What, How & Why?

Updated target link libraries list for the realm2json executable to remove the "duplicate libraries" warning:

[552/847] Linking CXX executable src/realm/exec/realm2json-dbg
ld: warning: ignoring duplicate libraries: 'src/realm/librealm-dbg.a'

The link libraries for realm2json were updated to match that of the SyncServer in src/realm/sync/noinst/server/CMakeLists.txt, which imports the same libraries.

☑️ ToDos

  • [ ] 📝 Changelog update
  • [ ] 🚦 Tests (or not relevant)
  • [ ] C-API, if public C++ API changed
  • [ ] bindgen/spec.yml, if public C++ API changed

@michael-wb michael-wb requested review from nicola-cab and ironage May 20, 2024 17:28
@cla-bot cla-bot bot added the cla: yes label May 20, 2024
@michael-wb michael-wb self-assigned this May 20, 2024
@michael-wb michael-wb added no-changelog no-jira-ticket Skip checking the PR title for Jira reference labels May 20, 2024
Copy link
Member

@nicola-cab nicola-cab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Storage implicitly linked by Sync right?

Copy link

Pull Request Test Coverage Report for Build michael.wilkersonbarker_1111

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 68 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.004%) to 90.819%

Files with Coverage Reduction New Missed Lines %
src/realm/sync/noinst/changeset_index.cpp 1 79.47%
src/realm/util/file.cpp 1 78.73%
src/realm/mixed.cpp 2 86.46%
src/realm/util/assert.hpp 4 87.1%
src/realm/sync/noinst/client_impl_base.cpp 5 82.99%
src/realm/sync/network/network.hpp 7 85.24%
src/realm/index_string.cpp 8 84.63%
src/realm/bplustree.cpp 13 71.41%
test/fuzz_group.cpp 13 52.15%
src/realm/sync/noinst/server/server.cpp 14 73.3%
Totals Coverage Status
Change from base Build 2318: 0.004%
Covered Lines: 214573
Relevant Lines: 236265

💛 - Coveralls

@michael-wb
Copy link
Contributor Author

Is Storage implicitly linked by Sync right?

It is implicitly linked by QueryParser.

@michael-wb michael-wb merged commit c6cb1ef into master May 20, 2024
43 of 47 checks passed
@michael-wb michael-wb deleted the mwb/fix-dup-lib-warning branch May 20, 2024 20:13
@fealebenpae fealebenpae mentioned this pull request May 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants