Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCORE-1952 Fsa/string interning #7654

Closed
wants to merge 2 commits into from
Closed

RCORE-1952 Fsa/string interning #7654

wants to merge 2 commits into from

Conversation

finnschiermer
Copy link
Contributor

Just triggering a CI run for now.

@cla-bot cla-bot bot added the cla: yes label May 1, 2024
@finnschiermer finnschiermer force-pushed the fsa/string-interning branch 3 times, most recently from 0089081 to b73d86e Compare May 8, 2024 07:42
@finnschiermer finnschiermer force-pushed the fsa/string-interning branch 2 times, most recently from b65b334 to 4301ee8 Compare May 18, 2024 13:23
@finnschiermer finnschiermer changed the base branch from nc/merge_all_together to nc/RCORE-2094 May 24, 2024 11:47
@finnschiermer finnschiermer force-pushed the fsa/string-interning branch from f52e23c to 7475efc Compare May 27, 2024 10:45
@nicola-cab nicola-cab force-pushed the nc/RCORE-2094 branch 2 times, most recently from b766478 to e2d8efe Compare May 28, 2024 11:02
@finnschiermer finnschiermer force-pushed the fsa/string-interning branch from e73f53e to cd52e63 Compare May 30, 2024 11:29
@nicola-cab nicola-cab force-pushed the nc/RCORE-2094 branch 2 times, most recently from aec70dc to 8762b1c Compare May 30, 2024 16:02
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented May 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build finn.schiermer-andersen_89

Details

  • 1005 of 1125 (89.33%) changed or added relevant lines in 15 files are covered.
  • 154 unchanged lines in 21 files lost coverage.
  • Overall coverage decreased (-0.03%) to 90.651%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/cluster.cpp 33 34 97.06%
src/realm/node.hpp 3 4 75.0%
src/realm/table.cpp 102 104 98.08%
src/realm/string_compressor.hpp 15 18 83.33%
src/realm/obj.cpp 19 23 82.61%
src/realm/array_string.cpp 52 70 74.29%
src/realm/string_compressor.cpp 233 267 87.27%
src/realm/string_interner.cpp 453 510 88.82%
Files with Coverage Reduction New Missed Lines %
src/realm/query_expression.hpp 1 93.81%
test/test_query2.cpp 1 98.73%
src/realm/array_string.cpp 2 85.52%
src/realm/cluster.cpp 2 74.65%
src/realm/object-store/shared_realm.cpp 2 91.89%
src/realm/query_expression.cpp 2 86.62%
src/realm/alloc.cpp 3 81.43%
src/realm/alloc.hpp 3 87.5%
src/realm/sync/noinst/client_impl_base.cpp 3 82.74%
src/realm/sync/noinst/protocol_codec.hpp 3 74.03%
Totals Coverage Status
Change from base Build nicola.cabiddu_1772: -0.03%
Covered Lines: 217953
Relevant Lines: 240431
💛 - Coveralls

@finnschiermer finnschiermer force-pushed the fsa/string-interning branch 2 times, most recently from 6e2c636 to f892749 Compare May 31, 2024 11:30
@nicola-cab nicola-cab force-pushed the nc/RCORE-2094 branch 2 times, most recently from fde48b9 to bda18e6 Compare June 6, 2024 12:45
Base automatically changed from nc/RCORE-2094 to next-major June 6, 2024 14:28
@finnschiermer finnschiermer force-pushed the fsa/string-interning branch from 36a80f4 to f97c242 Compare June 6, 2024 15:29
@finnschiermer finnschiermer force-pushed the fsa/string-interning branch from f97c242 to fcb50cd Compare June 6, 2024 15:31
@nicola-cab nicola-cab changed the title Fsa/string interning RCORE-1952 Fsa/string interning Jun 11, 2024
@evergreen-ci-prod evergreen-ci-prod bot mentioned this pull request Jun 12, 2024
Draft
4 tasks
@jedelbo
Copy link
Contributor

jedelbo commented Jun 12, 2024

Closing this PR. Superceded by #7803

@jedelbo jedelbo closed this Jun 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@finnschiermer @jedelbo @nicola-cab