Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RealmConfig::needs_file_format_upgrade #7336

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Feb 12, 2024

What, How & Why?

Fixes #7140

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@jedelbo
Copy link
Contributor Author

jedelbo commented Feb 12, 2024

@kneth is this what was requested?

Copy link

coveralls-official bot commented Feb 12, 2024

Pull Request Test Coverage Report for Build jorgen.edelbo_77

Details

  • 36 of 45 (80.0%) changed or added relevant lines in 6 files are covered.
  • 162 unchanged lines in 18 files lost coverage.
  • Overall coverage decreased (-0.04%) to 91.867%

Changes Missing Coverage Covered Lines Changed/Added Lines %
test/test_shared.cpp 8 10 80.0%
src/realm/object-store/c_api/config.cpp 0 3 0.0%
src/realm/db.cpp 19 23 82.61%
Files with Coverage Reduction New Missed Lines %
src/realm/index_string.cpp 1 87.85%
test/test_query2.cpp 1 99.08%
src/realm/array_string.cpp 2 88.0%
src/realm/cluster.cpp 2 80.36%
src/realm/sync/noinst/server/server_history.cpp 2 67.94%
src/realm/table_view.cpp 2 94.18%
test/object-store/util/test_file.cpp 2 89.64%
test/test_lang_bind_helper.cpp 2 93.31%
src/realm/sync/network/network.cpp 3 89.65%
test/test_util_network.cpp 3 97.2%
Totals Coverage Status
Change from base Build 2030: -0.04%
Covered Lines: 235412
Relevant Lines: 256253

💛 - Coveralls

@kneth
Copy link
Contributor

kneth commented Feb 13, 2024

@jedelbo Just what I need - thanks!

@jedelbo jedelbo merged commit 7df0def into master Feb 13, 2024
35 of 36 checks passed
@jedelbo jedelbo deleted the je/format-upgrade-and-migration branch February 13, 2024 12:49
@@ -163,6 +163,11 @@ RLM_API bool realm_config_get_disable_format_upgrade(const realm_config_t* confi
return config->disable_format_upgrade;
}

RLM_API bool realm_config_needs_file_format_upgrade(const realm_config_t* config)
{
return config->needs_file_format_upgrade();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method can throw.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method to check if file format upgrade is possible
5 participants