Fallback to manually consume space if posix_fallocate isn't supported at runtime #7251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes realm/realm-js#6349 and realm/realm-dotnet#3482.
I think this has emerged as an issue since the change in #7067 where the compile time detection of POSIX_FALLOCATE changed.
According to the man pages,
posix_fallocate
can return not supported:Fortunately for us, we do not rely on this and already have a fallback path so it is simply a matter of handling this error code in the same way. Testing this requires combination of a system that passes our compile time check but fails at runtime which we do not have yet.
☑️ ToDos
bindgen/spec.yml
, if public C++ API changed