Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update baas with the fix for "Test client migration and rollback with recovery" test #7164

Merged

Conversation

kiburtse
Copy link
Contributor

Update baas

What, How & Why?

The https://github.com/10gen/baas/pull/11975 should fix frequent failures of "Test client migration and rollback with recovery" and a few others which hit timeout on sync session and no activity within connection after triggering client reset.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

Copy link

coveralls-official bot commented Nov 23, 2023

Pull Request Test Coverage Report for Build kirill.burtsev_108

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 43 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.02%) to 91.684%

Files with Coverage Reduction New Missed Lines %
src/realm/sync/noinst/server/server.cpp 1 76.23%
src/realm/array_string.cpp 2 88.0%
src/realm/sync/noinst/client_impl_base.cpp 2 85.3%
src/realm/query_expression.cpp 3 87.01%
src/realm/sort_descriptor.cpp 3 93.7%
src/realm/unicode.cpp 4 90.15%
test/sync_fixtures.hpp 7 76.57%
src/realm/sync/network/network_ssl.hpp 8 85.95%
test/fuzz_group.cpp 13 57.75%
Totals Coverage Status
Change from base Build 1859: 0.02%
Covered Lines: 231447
Relevant Lines: 252441

💛 - Coveralls

@kiburtse kiburtse requested a review from ironage November 23, 2023 18:31
@kiburtse
Copy link
Contributor Author

heh surprising not much is needed for update, good to know.

What's the right way to temporarily disable tests requiring baas for some configurations? Specifically "baas-network-tests" for ubuntu2004-network-nonideal and ubuntu2004-network-faulty since they are not ready. tags: [ "disabled" ] doesn't work. Tests still run during nightly run

@kiburtse kiburtse merged commit 29f2454 into master Nov 23, 2023
1 of 2 checks passed
@kiburtse kiburtse deleted the kb/update_baas_with_fix_for_client_migration_rollback_test branch November 23, 2023 22:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants