Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop failing when sync is disabled and MacOs debug tests are set to run #7146

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Stop failing when sync is disabled and MacOs debug tests are set to run #7146

merged 6 commits into from
Nov 20, 2023

Conversation

nicola-cab
Copy link
Member

No description provided.

@nicola-cab nicola-cab force-pushed the nc/fix_cmake_debug_builder branch from f297ef8 to 83518a8 Compare November 17, 2023 11:09
@nicola-cab nicola-cab force-pushed the nc/fix_cmake_debug_builder branch from 83518a8 to 2827f64 Compare November 17, 2023 11:20
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Nov 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build nicola.cabiddu_1138

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 414 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-0.03%) to 91.67%
Files with Coverage Reduction New Missed Lines %
test/test_index_string.cpp 1 94.13%
src/realm/db.cpp 2 93.72%
src/realm/query_expression.hpp 2 93.51%
src/realm/sync/noinst/server/server_history.cpp 2 67.9%
src/realm/uuid.cpp 2 97.06%
src/realm/sync/noinst/protocol_codec.hpp 4 76.05%
src/realm/alloc_slab.cpp 5 92.89%
src/realm/set.cpp 6 93.57%
src/realm/sync/noinst/client_impl_base.cpp 9 85.09%
test/util/compare_groups.cpp 10 54.85%
Totals Coverage Status
Change from base Build 1845: -0.03%
Covered Lines: 231120
Relevant Lines: 252122
💛 - Coveralls

@nicola-cab nicola-cab force-pushed the nc/fix_cmake_debug_builder branch from 5dfd640 to a741512 Compare November 17, 2023 15:30
@nicola-cab nicola-cab force-pushed the nc/fix_cmake_debug_builder branch from a741512 to 5547f65 Compare November 17, 2023 15:30
@nicola-cab nicola-cab force-pushed the nc/fix_cmake_debug_builder branch from 38af431 to e353f39 Compare November 17, 2023 17:10
@nicola-cab nicola-cab requested a review from tgoyne November 17, 2023 17:11
@nicola-cab nicola-cab marked this pull request as ready for review November 17, 2023 17:12
@nicola-cab nicola-cab changed the title change cnf to always run cmake os debug builder Stop failing when sync is disabled and MacOs debug tests are set to run Nov 17, 2023
@nicola-cab nicola-cab requested a review from jedelbo November 20, 2023 10:32
jedelbo
jedelbo approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@jedelbo jedelbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicola-cab nicola-cab merged commit c5174be into master Nov 20, 2023
1 of 3 checks passed
@nicola-cab nicola-cab deleted the nc/fix_cmake_debug_builder branch November 20, 2023 10:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jedelbo jedelbo jedelbo approved these changes

@tgoyne tgoyne Awaiting requested review from tgoyne

Assignees

@nicola-cab nicola-cab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicola-cab @jedelbo