Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bindgen] Expose Obj::set_embedded() #7126

Merged
merged 2 commits into from
Nov 13, 2023
Merged

[bindgen] Expose Obj::set_embedded() #7126

merged 2 commits into from
Nov 13, 2023

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Nov 10, 2023

What, How & Why?

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

@kneth kneth requested a review from finnschiermer November 10, 2023 12:25
@kneth kneth requested a review from jedelbo November 10, 2023 12:25
elle-j
elle-j approved these changes Nov 10, 2023
View reviewed changes
bindgen/spec.yml Outdated Show resolved Hide resolved
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Nov 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build github_pull_request_284018

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 70 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.006%) to 91.67%
Files with Coverage Reduction New Missed Lines %
src/realm/array_string.cpp 2 88.0%
src/realm/object-store/shared_realm.cpp 2 93.74%
src/realm/table_view.cpp 2 94.18%
src/realm/util/file.cpp 2 81.73%
test/test_bplus_tree.cpp 2 99.42%
src/realm/sync/noinst/protocol_codec.hpp 3 76.72%
src/realm/sync/noinst/server/server_history.cpp 3 67.73%
src/realm/unicode.cpp 4 90.15%
src/realm/util/assert.hpp 4 87.1%
src/realm/sync/noinst/client_impl_base.cpp 7 85.62%
Totals Coverage Status
Change from base Build 1819: 0.006%
Covered Lines: 230813
Relevant Lines: 251787
💛 - Coveralls

@kneth kneth merged commit 9fa759e into master Nov 13, 2023
1 of 2 checks passed
@kneth kneth deleted the kneth/bindgen/expose-set_embedded branch November 13, 2023 14:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elle-j elle-j elle-j approved these changes

@jedelbo jedelbo jedelbo approved these changes

@finnschiermer finnschiermer Awaiting requested review from finnschiermer

Assignees

@kneth kneth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kneth @jedelbo @elle-j