Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly instantiate Set<ObjKey> in set.cpp #7121

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

tgoyne
Copy link
Member

@tgoyne tgoyne commented Nov 9, 2023

Set<ObjKey> is the single type not implicitly instantiated in Obj::get_setbase_ptr(), so it needs to be explicitly instantiated. Fixes the linker error seen in https://ci.realm.io/job/objc_pr/target=osx,xcode_version=14.3.1/10813/consoleFull. I have no idea why this works with LTO off but breaks with LTO on.

`Set<ObjKey>` is the single type not implicitly instantiated in
`Obj::get_setbase_ptr()`, so it needs to be explicitly instantiated.
@tgoyne tgoyne self-assigned this Nov 9, 2023
Copy link

Pull Request Test Coverage Report for Build github_pull_request_283538

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 96 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.005%) to 91.659%

Files with Coverage Reduction New Missed Lines %
src/realm/collection.hpp 1 91.05%
src/realm/index_string.cpp 1 87.81%
src/realm/sync/noinst/client_impl_base.hpp 1 93.91%
test/test_dictionary.cpp 1 99.85%
src/realm/array_string.cpp 2 88.0%
src/realm/object-store/shared_realm.cpp 2 93.74%
src/realm/table_view.cpp 2 94.18%
src/realm/util/file.cpp 2 81.73%
src/realm/sync/noinst/protocol_codec.hpp 3 76.72%
src/realm/util/assert.hpp 4 87.1%
Totals Coverage Status
Change from base Build 1819: -0.005%
Covered Lines: 230790
Relevant Lines: 251793

💛 - Coveralls

@jedelbo jedelbo merged commit 37c18a9 into master Nov 14, 2023
3 checks passed
@jedelbo jedelbo deleted the tg/set-linker-error branch November 14, 2023 07:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants