-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge feature/network-faultiness branch into master #7120
Conversation
… with non-ideal network conditions (#6852) * Added support for starting baas proxy * Fixed some issues when running the scripts * minor updates to install_baas.sh * Updates to scripts to run on evergreen spawn host * Added total time output to object store tests * Increased initial ssh connect attempts; renamed proxy to 'baas_proxy' * Minor updates to help output * Added baas network test to run bass with the proxy * Added support for separate baas admin api url value * Minor port check adjustments * Removed 'compile' task from network_tests * Disable development mode by default * Added baas remote host and network tests instructions doc * Minor updates to the instructions * Minor updates to documentation
… conditions (#7063) * Added non-ideal transfer and network fault tests * Added baas-network-tests to be allowed for PR runs * Updated changelog * Updated curl command to be silent * Updated changelog * Reverted some changes and added descriptions to config.yml
…til fixes are added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a quick look, but all these changes have been reviewed already in separate PRs right?
@@ -899,6 +967,31 @@ tasks: | |||
verbose_test_output: true | |||
- func: "check branch state" | |||
|
|||
- name: baas-network-tests | |||
# Uncomment once tests are passing | |||
# tags: [ "for_nightly_tests" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be uncommented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are disabled for now until some of the failures can be addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the entire suite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the primary task that is used by both tests - so both tests are disabled.
The test parameters (non-ideal vs faulty networks) are configured by the variant for that test.
What, How & Why?
Integrating the network faultiness project changes into master. Some of these changes include:
constants.h
for baas dependency defines☑️ ToDos
[ ] C-API, if public C++ API changed.