Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge feature/network-faultiness branch into master #7120

Merged
merged 16 commits into from
Nov 14, 2023

Conversation

michael-wb
Copy link
Contributor

What, How & Why?

Integrating the network faultiness project changes into master. Some of these changes include:

  • Updated baas tests to disable development mode by default
  • Added extra testing delay for non-ideal network tests
  • Added toxiproxy support for network faulty tests
  • Added separate baas admin host configuration to skip the proxy to avoid false failures
  • Updated install_baas to use go 1.21
  • Preliminary changes to use baas repo constants.h for baas dependency defines
  • Updated remote baas scripts to run on evergreen ubuntu and RHEL spawn hosts

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • [ ] C-API, if public C++ API changed.

Michael Wilkerson-Barker added 9 commits August 31, 2023 10:27
… with non-ideal network conditions (#6852)

* Added support for starting baas proxy
* Fixed some issues when running the scripts
* minor updates to install_baas.sh
* Updates to scripts to run on evergreen spawn host
* Added total time output to object store tests
* Increased initial ssh connect attempts; renamed proxy to 'baas_proxy'
* Minor updates to help output
* Added baas network test to run bass with the proxy
* Added support for separate baas admin api url value
* Minor port check adjustments
* Removed 'compile' task from network_tests
* Disable development mode by default
* Added baas remote host and network tests instructions doc
* Minor updates to the instructions
* Minor updates to documentation
… conditions (#7063)

* Added non-ideal transfer and network fault tests
* Added baas-network-tests to be allowed for PR runs
* Updated changelog
* Updated curl command to be silent
* Updated changelog
* Reverted some changes and added descriptions to config.yml
Copy link

coveralls-official bot commented Nov 7, 2023

Pull Request Test Coverage Report for Build michael.wilkersonbarker_923

  • 179 of 192 (93.23%) changed or added relevant lines in 14 files are covered.
  • 77 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.002%) to 91.688%

Changes Missing Coverage Covered Lines Changed/Added Lines %
test/object-store/util/sync/sync_test_utils.hpp 3 4 75.0%
test/object-store/util/test_file.cpp 2 3 66.67%
test/object-store/util/sync/sync_test_utils.cpp 31 42 73.81%
Files with Coverage Reduction New Missed Lines %
test/test_query2.cpp 1 99.08%
src/realm/object-store/shared_realm.cpp 2 93.74%
src/realm/object-store/sync/app.hpp 3 81.48%
src/realm/sync/instruction_applier.cpp 3 70.0%
test/object-store/util/sync/baas_admin_api.hpp 3 91.43%
src/realm/sync/network/websocket.cpp 4 74.23%
src/realm/sync/noinst/client_reset.cpp 4 93.49%
src/realm/sync/noinst/protocol_codec.hpp 4 76.05%
test/object-store/util/sync/sync_test_utils.cpp 4 92.73%
src/realm/sync/noinst/server/server.cpp 5 76.55%
Totals Coverage Status
Change from base Build 1831: -0.002%
Covered Lines: 231144
Relevant Lines: 252099

💛 - Coveralls

Copy link
Collaborator

@danieltabacaru danieltabacaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick look, but all these changes have been reviewed already in separate PRs right?

@@ -899,6 +967,31 @@ tasks:
verbose_test_output: true
- func: "check branch state"

- name: baas-network-tests
# Uncomment once tests are passing
# tags: [ "for_nightly_tests" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be uncommented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are disabled for now until some of the failures can be addressed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the entire suite?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the primary task that is used by both tests - so both tests are disabled.
The test parameters (non-ideal vs faulty networks) are configured by the variant for that test.

@michael-wb michael-wb merged commit 55b0c8b into master Nov 14, 2023
2 checks passed
@michael-wb michael-wb deleted the feature/network-faultyness branch November 14, 2023 03:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants