Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused stuff #7108

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Remove unused stuff #7108

merged 1 commit into from
Nov 3, 2023

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Nov 2, 2023

What, How & Why?

This code was used in migration code that was removed earlier.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

Copy link

Pull Request Test Coverage Report for Build github_pull_request_282426

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 66 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.06%) to 90.584%

Files with Coverage Reduction New Missed Lines %
test/test_dictionary.cpp 1 99.85%
src/realm/array_string.cpp 2 85.04%
src/realm/db.cpp 2 93.13%
src/realm/object-store/shared_realm.cpp 2 93.74%
src/realm/query_engine.hpp 2 93.94%
src/realm/sort_descriptor.cpp 3 93.8%
src/realm/sync/client.cpp 3 90.75%
src/realm/sync/noinst/server/server_history.cpp 3 67.63%
src/realm/sync/noinst/client_impl_base.cpp 4 85.42%
src/realm/sync/transform.cpp 4 61.68%
Totals Coverage Status
Change from base Build github_pull_request_281750: 0.06%
Covered Lines: 233534
Relevant Lines: 257808

💛 - Coveralls

@jedelbo jedelbo merged commit 05320ae into next-major Nov 3, 2023
2 of 3 checks passed
@jedelbo jedelbo deleted the je/clean-up branch November 3, 2023 09:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants