Handle client resets during schema migrations + integration tests #7106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_integration_tests
|
@michael-wb Let's review the tests and the other changes and not worry about tests failing for now. Once I merge this into the feature branch, I will rebase master (which is still pending some changes from James), and then the tests should pass. |
michael-wb
reviewed
Nov 8, 2023
danieltabacaru
merged commit e94cd37
into
feature/sync_schema_migrations
2 checks passed
danieltabacaru
added a commit
that referenced
this pull request
Jan 22, 2024
* Add schema version to flexible sync client BIND message (#6863) * Send schema version as part of BIND messages * Add pause_async to SyncSession (#6845) * Add async shutdown of SyncSession * SyncSession::shutdown returns a Future instead of passing callbacks around * Rename shutdown() to pause_async(). Hide it from the public API. * Remove unneeded header import * Upload data and migrate schema (#6944) * Handle client resets during schema migrations + integration tests (#7106) * Add option to use draft deployments when creating a schema for baas tests * Track sync schema migration between sessions + minor refactoring * Integration tests * Bump sync protocol version to 11 * Update baas commit for evergreen tests * Allow resetting schema version to zero * Improve changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
During sync schema migrations, an uploaded change may trigger a client reset on the server. If the client reset is interrupted, then when the app restarts or the session is resumed the server sends only the client reset error (without sending the migration error with the previous schema version). The client therefore needs to store the previous schema version and have it available until the migration is completed. A new (private) metadata table schema_migration_metadata is added for this purpose.
In addition, integration tests have been added to test several scenarios.
Fixes #7023, #6956.
☑️ ToDos
[ ] 📝 Changelog update[ ] C-API, if public C++ API changed.