Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validate-installed-headers test #7103

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

michael-wb
Copy link
Contributor

What, How & Why?

The validate-installed-headers test was failing since the query_state.hpp file was using a class without including the file.

☑️ ToDos

  • [ ] 📝 Changelog update
  • [ ] 🚦 Tests (or not relevant)
  • [ ] C-API, if public C++ API changed.

Copy link

Pull Request Test Coverage Report for Build michael.wilkersonbarker_907

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 218 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-0.05%) to 91.591%

Files with Coverage Reduction New Missed Lines %
src/realm/aggregate_ops.hpp 1 97.84%
src/realm/util/file.cpp 1 81.73%
src/realm/array_blobs_big.cpp 2 98.72%
src/realm/cluster.cpp 2 80.25%
src/realm/query_expression.hpp 2 93.43%
src/realm/sync/network/websocket.cpp 2 75.36%
src/realm/util/fifo_helper.cpp 2 85.71%
src/realm/uuid.cpp 2 97.06%
test/test_util_network.cpp 3 97.2%
src/realm/sync/network/network.cpp 4 89.86%
Totals Coverage Status
Change from base Build 1796: -0.05%
Covered Lines: 230718
Relevant Lines: 251899

💛 - Coveralls

@michael-wb michael-wb merged commit ac771aa into master Nov 1, 2023
5 checks passed
@michael-wb michael-wb deleted the mwb/fix-validate-headers branch November 1, 2023 16:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants