Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make undefined sanitizer work on Linux #7082

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Make undefined sanitizer work on Linux #7082

merged 1 commit into from
Oct 27, 2023

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Oct 26, 2023

What, How & Why?

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

@jedelbo jedelbo requested a review from ironage October 26, 2023 13:55
@coveralls-official
Copy link

Pull Request Test Coverage Report for Build github_pull_request_281465

  • 18 of 22 (81.82%) changed or added relevant lines in 1 file are covered.
  • 40 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.03%) to 91.579%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/array_with_find.hpp 18 22 81.82%
Files with Coverage Reduction New Missed Lines %
test/test_dictionary.cpp 1 99.85%
src/realm/array_string.cpp 2 87.78%
src/realm/sync/noinst/client_impl_base.cpp 2 85.84%
test/fuzz_group.cpp 3 54.97%
test/sync_fixtures.hpp 3 76.57%
src/realm/sync/instructions.hpp 4 75.52%
src/realm/sync/noinst/protocol_codec.hpp 4 75.54%
src/realm/sync/transform.cpp 4 61.71%
src/realm/unicode.cpp 4 90.15%
src/realm/sync/noinst/server/server.cpp 5 75.69%
Totals Coverage Status
Change from base Build 1777: 0.03%
Covered Lines: 230634
Relevant Lines: 251842
💛 - Coveralls

ironage
ironage approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See also #6911

@jedelbo jedelbo merged commit 4200f2b into master Oct 27, 2023
@jedelbo jedelbo deleted the je/usan branch October 27, 2023 08:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ironage ironage ironage approved these changes

Assignees

@jedelbo jedelbo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedelbo @ironage