Logging notification activity #7072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build github_pull_request_281106
💛 - Coveralls |
jedelbo
force-pushed
the
je/notification-logging
branch
2 times, most recently
from
94394fd to
1d634e6
Compare
jedelbo
force-pushed
the
je/notification-logging
branch
from
1d634e6 to
8383daa
Compare
ironage
reviewed
Oct 23, 2023
| } | ||
|
|
||
| ~ScopeExit() noexcept | ||
| ~ScopeExit() |
There was a problem hiding this comment.
Isn't it necessary to have a noexcept destructor? There is a static assert about this.
There was a problem hiding this comment.
Noexcept is the default for destructors and explicitly marking them as noexcept is cosmetic.
ironage
reviewed
Oct 23, 2023
test/test_parser.cpp
Outdated
| @@ -514,6 +514,8 @@ TEST(Parser_empty_input) | |||
|
|
|||
| TEST(Parser_ConstrainedQuery) | |||
| { | |||
| // We no longer thorow when serializing a constrained query, | |||
There was a problem hiding this comment.
Suggested change
| // We no longer thorow when serializing a constrained query, | |
| // We no longer throw when serializing a constrained query, |
ironage
reviewed
Oct 23, 2023
test/test_parser.cpp
Outdated
| @@ -514,6 +514,8 @@ TEST(Parser_empty_input) | |||
|
|
|||
| TEST(Parser_ConstrainedQuery) | |||
| { | |||
| // We no longer thorow when serializing a constrained query, | |||
| // but the decription cannot be used to build a new query | |||
There was a problem hiding this comment.
Suggested change
| // but the decription cannot be used to build a new query | |
| // but the description cannot be used to build a new query |
ironage
reviewed
Oct 23, 2023
| @@ -5414,7 +5414,7 @@ TEST(Table_LoggingMutations) | |||
| CHECK(str.find("abcdefghijklmno ...") != std::string::npos); | |||
| CHECK(str.find("14 15 16 17 18 19 ...") != std::string::npos); | |||
| CHECK(str.find("2023-09-20 10:53:35") != std::string::npos); | |||
| CHECK(str.find("Query::get_description() failed:") != std::string::npos); | |||
| CHECK(str.find("VIEW { 6 element(s) }") != std::string::npos); | |||
jedelbo
force-pushed
the
je/notification-logging
branch
from
8383daa to
c5d1118
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Fixes #7050
☑️ ToDos