-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fsa/report mmap on failure #7057
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build github_pull_request_284258
💛 - Coveralls |
finnschiermer
force-pushed
the
fsa/report-mmap-on-failure
branch
from
October 20, 2023 12:40
95f74be
to
6a1fa67
Compare
finnschiermer
force-pushed
the
fsa/report-mmap-on-failure
branch
from
October 25, 2023 05:59
a49b5ef
to
aa98846
Compare
finnschiermer
force-pushed
the
fsa/report-mmap-on-failure
branch
from
October 26, 2023 09:52
4dd174d
to
33e18c0
Compare
finnschiermer
force-pushed
the
fsa/report-mmap-on-failure
branch
from
October 27, 2023 10:48
e888d37
to
c45aefb
Compare
finnschiermer
force-pushed
the
fsa/report-mmap-on-failure
branch
2 times, most recently
from
October 30, 2023 17:03
c8aa42f
to
d80dcaa
Compare
finnschiermer
force-pushed
the
fsa/report-mmap-on-failure
branch
from
October 31, 2023 13:17
df14682
to
cbf621d
Compare
jedelbo
requested changes
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to have a unit test for memory mapping where the logging functionality is exercised.
Review to be continued.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This PR
The format of the dumped list is as follows: