code review

realm · Jul 12, 2024 · 2f1210b · 2f1210b
1 parent 8830dca
commit 2f1210b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/src/realm.h b/src/realm.h
@@ -1243,8 +1243,6 @@ RLM_API uint64_t realm_get_schema_version(const realm_t* realm);
 
 /**
  * Get the schema version for this realm at the path.
- *
- * This function cannot fail.
  */
 RLM_API uint64_t realm_get_persisted_schema_version(const realm_config_t* config);
 

diff --git a/src/realm/object-store/c_api/schema.cpp b/src/realm/object-store/c_api/schema.cpp
@@ -68,13 +68,11 @@ RLM_API uint64_t realm_get_persisted_schema_version(const realm_config_t* config
         conf.force_sync_history = true;
     }
 
-    return wrap_err([&]() {
-        auto realm = new shared_realm{Realm::get_shared_realm(conf)};
-        uint64_t version = ObjectStore::get_schema_version(realm->get()->read_group());
-        delete realm;
+    auto realm = new shared_realm{Realm::get_shared_realm(conf)};
+    uint64_t version = ObjectStore::get_schema_version(realm->get()->read_group());
+    delete realm;
 
-        return version;
-    });
+    return version;
 }
 
 RLM_API bool realm_schema_validate(const realm_schema_t* schema, uint64_t validation_mode)
-Original file line number
+Diff line change
@@ Expand Up @@
     /**
      * Get the schema version for this realm at the path.
-     *
-     * This function cannot fail.
      */
     RLM_API uint64_t realm_get_persisted_schema_version(const realm_config_t* config);
@@ Expand Down @@