Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jinyoungchoi95-issue70] Article 좋아요기능 구현 #71

Merged
merged 15 commits into from
Oct 30, 2021

Conversation

jinyoungchoi95
Copy link
Member

Issue: #70

작업 내용

  • Article favorite 컬럼 추가
  • 좋아요 기능 구현
  • 좋아요 수 count 기능 구현

생성/변경 로직

  • Article - user favorite테이블 연결 필드 추가
  • 좋아요 / 좋아요 취소 기능 구현

@kwj1270
Copy link

kwj1270 commented Oct 29, 2021

실시간 코드리뷰?

Copy link

@kwj1270 kwj1270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

크게 리뷰드릴점은 없습니다.
다만 패키지 구조만 조금 변경하면 좋을 것 같아요

  • domain
    • tag
    • user
    • artice
    • comment(분리)
  • global
    • security
    • 기타 등등

그리고 Article 애그리거트 루트가 동일 패키지의 다른 VO랑 많이 섞여있는 것 같은데
제 기준 루트애그리거트+레포 포함 5개 이상이되면 패키지 나누는 것 같아요!!

@jinyoungchoi95
Copy link
Member Author

크게 리뷰드릴점은 없습니다. 다만 패키지 구조만 조금 변경하면 좋을 것 같아요

  • domain

    • tag
    • user
    • artice
    • comment(분리)
  • global

    • security
    • 기타 등등

그리고 Article 애그리거트 루트가 동일 패키지의 다른 VO랑 많이 섞여있는 것 같은데 제 기준 루트애그리거트+레포 포함 5개 이상이되면 패키지 나누는 것 같아요!!

@kwj1270 comment는 분리할까말까 고민하고있었어서 다른분 의견이 궁금했는데 이렇게 보니역시 분리하는게 좋아보이긴 하네요 :)

security관련해서도 말씀해주신 방법을 보니 더 좋아보입니다! 🙆‍♂️ (팔랑팔랑)

@codecov-commenter
Copy link

Codecov Report

Merging #71 (e2623a4) into jinyoungchoi95 (580adce) will increase coverage by 0.06%.
The diff coverage is 92.72%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             jinyoungchoi95      #71      +/-   ##
====================================================
+ Coverage             91.29%   91.36%   +0.06%     
- Complexity              353      373      +20     
====================================================
  Files                    58       59       +1     
  Lines                   931      984      +53     
  Branches                 33       34       +1     
====================================================
+ Hits                    850      899      +49     
- Misses                   37       39       +2     
- Partials                 44       46       +2     
Impacted Files Coverage Δ
...ealworld/comment/controller/CommentController.java 100.00% <ø> (ø)
...mment/controller/request/CommentCreateRequest.java 100.00% <ø> (ø)
...d/comment/controller/response/CommentResponse.java 90.47% <ø> (ø)
.../comment/controller/response/CommentsResponse.java 100.00% <ø> (ø)
...va/com/study/realworld/comment/domain/Comment.java 73.07% <ø> (ø)
...om/study/realworld/comment/domain/CommentBody.java 76.47% <ø> (ø)
...tudy/realworld/comment/service/CommentService.java 100.00% <ø> (ø)
...udy/realworld/global/config/WebSecurityConfig.java 100.00% <ø> (ø)
...m/study/realworld/global/security/JjwtService.java 100.00% <ø> (ø)
...y/realworld/global/security/JwtAuthentication.java 100.00% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580adce...e2623a4. Read the comment docs.

@jinyoungchoi95 jinyoungchoi95 merged commit 36ab6bc into jinyoungchoi95 Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ori 오리의 이슈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants