-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jinyoungchoi95-issue70] Article 좋아요기능 구현 #71
Conversation
실시간 코드리뷰? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
크게 리뷰드릴점은 없습니다.
다만 패키지 구조만 조금 변경하면 좋을 것 같아요
- domain
- tag
- user
- artice
- comment(분리)
- global
- security
- 기타 등등
그리고 Article 애그리거트 루트가 동일 패키지의 다른 VO랑 많이 섞여있는 것 같은데
제 기준 루트애그리거트+레포
포함 5개 이상이되면 패키지 나누는 것 같아요!!
@kwj1270 comment는 분리할까말까 고민하고있었어서 다른분 의견이 궁금했는데 이렇게 보니역시 분리하는게 좋아보이긴 하네요 :) security관련해서도 말씀해주신 방법을 보니 더 좋아보입니다! 🙆♂️ (팔랑팔랑) |
Codecov Report
@@ Coverage Diff @@
## jinyoungchoi95 #71 +/- ##
====================================================
+ Coverage 91.29% 91.36% +0.06%
- Complexity 353 373 +20
====================================================
Files 58 59 +1
Lines 931 984 +53
Branches 33 34 +1
====================================================
+ Hits 850 899 +49
- Misses 37 39 +2
- Partials 44 46 +2
Continue to review full report at Codecov.
|
Issue: #70
작업 내용
생성/변경 로직