[chance0523-issue32] jwt 구현 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String header = request.getHeader(HttpHeaders.AUTHORIZATION); | ||
|
|
||
| String[] headers = header.split(" "); | ||
| if (headers.length == 2 && headers[0].equals("Token") && StringUtils.hasText(headers[1])) { |
There was a problem hiding this comment.
이부분은 제가 예제 코드에서 예제로써 쉽게 풀어내려고 하드코딩했는데 조금 개선해보는것도 좋을 것 같아요 :)
hoony-lab
reviewed
Aug 26, 2021
| @@ -33,12 +33,15 @@ | |||
|
|
|||
| private final String image; | |||
|
|
|||
| public static UserResponse createResponse(User user) { | |||
| private final String accessToken; | |||
There was a problem hiding this comment.
아 token이 api 스펙이었네요
수정했습니다 👍
Comment on lines
+39
to
+41
| //@Formatter:off | ||
| @WebMvcTest({UserController.class, SecurityConfig.class, JwtAuthenticationEntryPoint.class, JwtAccessDeniedHandler.class}) | ||
| //@Formatter:on |
There was a problem hiding this comment.
//@Formatter:off 얘와
//@Formatter:on 얘 사이에 있는 코드는
포맷팅이 되지 않습니다! (자동정렬 안 먹음)
| * @author JeongJoon Seo | ||
| */ | ||
| @Component | ||
| public class JwtAccessDeniedHandler implements AccessDeniedHandler { |
| * @author JeongJoon Seo | ||
| */ | ||
| @Component | ||
| public class JwtAuthenticationEntryPoint implements AuthenticationEntryPoint { |
Codecov Report
@@ Coverage Diff @@
## chance0523 #35 +/- ##
================================================
- Coverage 100.00% 94.44% -5.56%
- Complexity 17 28 +11
================================================
Files 10 16 +6
Lines 41 90 +49
Branches 0 1 +1
================================================
+ Hits 41 85 +44
- Misses 0 4 +4
- Partials 0 1 +1
Continue to review full report at Codecov.
|
DolphaGo
reviewed
Aug 27, 2021
| /** | ||
| * @author Jeongjoon Seo | ||
| */ | ||
| @Configuration | ||
| @EnableGlobalMethodSecurity(prePostEnabled = true) |
There was a problem hiding this comment.
이건 어떤 역할을 하는 어노테이션인지 간략한 설명 부탁드립니다 (_ _)
There was a problem hiding this comment.
이거 뭔가 인프런 강의 따라 치다가 들어간 것 같은데요...
https://ncucu.me/136
위 블로그를 참고해보면
- Spring Security는 Web기반의 Security 외에 Method Security 기능을 제공하는데
Method Security는 우리가 기존에 사용했던 SecurityConfig 설정이 적용되지 않는다.
- Method Security용 설정이 따로 필요한데 이때 사용하는것이 **@EnableGlobalMethodSecurity**이다.
- `prePostEnabled`은 @PreAuthorize, @PostAuthorize을 사용할 수 있게 해줍니다 (여기서는 사용하지 않았습니다)
이정도?로 정리할 수 있겠네요. 아마 지금은 EnableGlobalMethodSecurity의 기능을 쓰고 있지 않는 것 같아서 없어도 되는 코드 같기도 하네요 (어려운 Spring Security.. 정확히 설명을 못 드리겠습니다 ㅠ_ㅠ)
kwj1270
approved these changes
Aug 29, 2021
| String header = request.getHeader(HttpHeaders.AUTHORIZATION); | ||
|
|
||
| String[] headers = header.split(" "); | ||
| if (headers.length == 2 && headers[0].equals("Token") && StringUtils.hasText(headers[1])) { |
jinyoungchoi95
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #32
작업 내용
생성/변경 로직
개인 코멘트