Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _Opt deprecation warnings #313

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Fix _Opt deprecation warnings #313

merged 3 commits into from
Dec 2, 2024

Conversation

Zac-HD
Copy link
Contributor

@Zac-HD Zac-HD commented Oct 10, 2024

Fixes #312.


📚 Documentation preview 📚: https://sphinx-hoverxref--313.org.readthedocs.build/en/313/

@Zac-HD Zac-HD requested a review from a team as a code owner October 10, 2024 07:46
@Zac-HD Zac-HD requested a review from stsewd October 10, 2024 07:46
@stsewd stsewd requested review from humitos and removed request for stsewd October 10, 2024 14:10
Copy link

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this in trio's RTD logs just now!

hoverxref/extension.py Outdated Show resolved Hide resolved
@Zac-HD
Copy link
Contributor Author

Zac-HD commented Nov 29, 2024

@humitos I just ran into this again downstream; is there anything else I need to do for the PR to be mergeable?

@humitos humitos merged commit f702d3e into readthedocs:main Dec 2, 2024
6 checks passed
@Zac-HD Zac-HD deleted the patch-1 branch December 2, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning with Sphinx v8.0.2
3 participants