Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(zh-hant): Translate FAQ: AJAX and APIs #3

Merged
merged 1 commit into from
Feb 14, 2019
Merged

docs(zh-hant): Translate FAQ: AJAX and APIs #3

merged 1 commit into from
Feb 14, 2019

Conversation

JuanitoFatas
Copy link
Contributor

@JuanitoFatas JuanitoFatas commented Feb 10, 2019 •
edited
Loading

This Pull Request translates AJAX and APIs page:

How to preview

git clone [email protected]:reactjs/zh-hant.reactjs.org.git
git am -3 https://github.com/reactjs/zh-hant.reactjs.org/pull/3
yarn dev 
open http://localhost:8000/docs/faq-ajax.html
Click to view translated page from this Pull Request

localhost_8000_docs_faq-ajax html

Reference

See the tracking issue of progress: #1

@JuanitoFatas JuanitoFatas force-pushed the zh-handt/faq-ajax-and-apis branch from 390b23c to d14575e Compare February 10, 2019 08:34
JuanitoFatas
JuanitoFatas commented Feb 10, 2019
View reviewed changes
@tesseralis tesseralis requested a review from chloewlin February 11, 2019 22:02
chloewlin
chloewlin reviewed Feb 12, 2019
View reviewed changes
@tesseralis tesseralis mentioned this pull request Feb 12, 2019
Closed
92 tasks
@JuanitoFatas JuanitoFatas force-pushed the zh-handt/faq-ajax-and-apis branch from 7d1be7a to 45b6f14 Compare February 13, 2019 14:09
@JuanitoFatas JuanitoFatas force-pushed the zh-handt/faq-ajax-and-apis branch from 45b6f14 to 5a426bc Compare February 13, 2019 14:11
@JuanitoFatas
Copy link
Contributor Author

Thanks for the review, suggestions have been applied.

@JuanitoFatas JuanitoFatas mentioned this pull request Feb 13, 2019
Merged
bugtender
bugtender approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@bugtender bugtender left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tesseralis
Copy link
Member

@chloewlin are you ready to merge this or do you want another review first?

@chloewlin
Copy link
Member

chloewlin commented Feb 14, 2019 •
edited
Loading

@tesseralis I think it's ready to be merged! Should I merge it? :)

@tesseralis
Copy link
Member

@chloewlin you are one of the maintainers, so it's your decision :)

It's also a good thing to decide how many reviews you want before you merge something in, and to set that in the repo config.

@chloewlin
Copy link
Member

chloewlin commented Feb 14, 2019 •
edited
Loading

@tesseralis got it. Currently we only have a few PRs, but there are already quite a few stylistic inconsistencies (some contributors like to translate everything, some would like to use English). We haven't decided this yet, but I will follow up with everyone and streamline our workflow in the next few days!

But this one is ready to go. I will merge it now.

@chloewlin chloewlin merged commit 8c4480b into reactjs:master Feb 14, 2019
@tesseralis
Copy link
Member

@chloewlin yay! Let me know if you need my help in that process of deciding terms.

@JuanitoFatas JuanitoFatas deleted the zh-handt/faq-ajax-and-apis branch February 14, 2019 09:24
rickhanlonii added a commit that referenced this pull request Apr 22, 2023
@rickhanlonii @gaearon
Fix alternate lang tags (#3)
9deda00 
* Fix alternate lang tags

* prettier

* Scope down the change

---------

Co-authored-by: Dan Abramov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itszero itszero itszero left review comments

@chentsulin chentsulin chentsulin left review comments

@neighborhood999 neighborhood999 neighborhood999 left review comments

@chloewlin chloewlin chloewlin left review comments

@bugtender bugtender bugtender approved these changes

Assignees
No one assigned
Labels
Completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JuanitoFatas @tesseralis @chloewlin @itszero @chentsulin @bugtender @neighborhood999