Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"You Might Not Need an Effect" の翻訳を変更 #733

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

smikitky
Copy link
Member

@smikitky smikitky commented Feb 7, 2024

タイトルだけ見て「useEffect は問答無用で使うな!」のような方向の勘違いをしている人が目についてしまうので、内容を反映した少し穏当なタイトルに変えてみたいと思うのですが、如何でしょうか…

Copy link

github-actions bot commented Feb 7, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 80.32 KB (-1 B) 184.26 KB
/500 80.32 KB (-1 B) 184.25 KB
/[[...markdownPath]] 82.18 KB (-1 B) 186.11 KB
/errors 80.5 KB (-1 B) 184.44 KB
/errors/[errorCode] 80.48 KB (-1 B) 184.42 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

特に違和感ありません 👍

@smikitky smikitky merged commit 54d36bf into main Feb 13, 2024
5 checks passed
@smikitky smikitky deleted the change-title branch February 13, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants