Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: translate for preconnect page (#691) #712

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

andriawan
Copy link
Contributor

@andriawan andriawan commented Jul 1, 2024

Closes #691

Description

Translate the page.
Page URL: https://id.react.dev/reference/react-dom/preconnect

Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
id-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 1:15pm

Copy link

github-actions bot commented Jul 1, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@andriawan andriawan force-pushed the translate-preconnect-pages branch from 337dc4f to 8e4e11c Compare July 1, 2024 06:29
@andriawan andriawan marked this pull request as ready for review July 2, 2024 13:15
@andriawan
Copy link
Contributor Author

this PR is ready to reveiw @resir014

@andriawan andriawan changed the title Initial translate for preconnect pages (#691) Translate for preconnect pages (#691) Jul 5, 2024
@andriawan andriawan changed the title Translate for preconnect pages (#691) docs: translate for preconnect page (#691) Jul 11, 2024
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change needed - please review! @andriawan

@andriawan
Copy link
Contributor Author

done @resir014

@andriawan andriawan requested a review from resir014 July 11, 2024 13:17
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@resir014 resir014 merged commit 9b1448e into reactjs:main Jul 11, 2024
5 checks passed
@andriawan andriawan deleted the translate-preconnect-pages branch July 12, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preconnect
2 participants