Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added external styling for propdrawer & playground #60

Closed
wants to merge 7 commits into from
Closed

Added external styling for propdrawer & playground #60

wants to merge 7 commits into from

Conversation

shivambalwani
Copy link

issue #3 :
Added External Styling for the Components Propdrawer and Playground.

@netlify
Copy link

netlify bot commented Mar 13, 2021 •
edited
Loading

Deploy preview for rne-playground processing.

Building with commit 1cec089

https://app.netlify.com/sites/rne-playground/deploys/6055aa244bfa7600080084e1

tewarig
tewarig reviewed Mar 13, 2021
View reviewed changes
src/components/PropDrawer/index.jsx Outdated
paddingLeft: "1rem",
}}
>
<div className={styles.propdrawer__child}>
Copy link
Contributor

@tewarig tewarig Mar 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a suggestion we can use camel casing here ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And pls remove the child and rename to something more intuitive

Uyadav207
Uyadav207 reviewed Mar 13, 2021
View reviewed changes
Copy link
Contributor

@Uyadav207 Uyadav207 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2021-03-13 22-42-01

  • Breaking UI.

@Uyadav207
Copy link
Contributor

Uyadav207 commented Mar 13, 2021 •
edited
Loading

I think if you are changing UI, please make a discussion for that particular UI issue.
Possible Solution

I hope it makes any sense.
Thanks.

@tewarig
Copy link
Contributor

tewarig commented Mar 13, 2021 •
edited
Loading

I think if you are changing UI, please make a discussion for that particular UI issue.
Possible Solution

I hope it makes any sense.
Thanks.

@shivambalwani
I tried to see what is causing this UI to break.
have a look at the elements.style in this pr
Screenshot from 2021-03-13 23-04-33
elements.style in the main deployment.
Screenshot from 2021-03-13 23-00-09
just figure out a way to add these styles. hope it helps.

@shivambalwani
Copy link
Author

I think if you are changing UI, please make a discussion for that particular UI issue.
Possible Solution

I hope it makes any sense.
Thanks.

@shivambalwani
I tried to see what is causing this UI to break.
have a look at the elements.style in this pr
Screenshot from 2021-03-13 23-04-33
elements.style in the main deployment.
Screenshot from 2021-03-13 23-00-09
just figure out a way to add these styles. hope it helps.

thanks!

pranshuchittora
pranshuchittora reviewed Mar 19, 2021
View reviewed changes
src/components/playground/playground.module.css Outdated
@@ -0,0 +1,4 @@
.playground{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rename it to something container

pranshuchittora
pranshuchittora requested changes Mar 19, 2021
View reviewed changes
Copy link
Member

@pranshuchittora pranshuchittora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

@shivambalwani
Copy link
Author

Left some comments

@pranshuchittora i have fixed the style naming, but the checks are failing. I don't know why?

@pranshuchittora
Copy link
Member

Oops!
Pls pull the new changes & resolve the conflicts.

@shivambalwani
Copy link
Author

shivambalwani commented Apr 4, 2021 •
edited
Loading

Oops!
Pls pull the new changes & resolve the conflicts.

pulled the new changes still unable to resolve.Still Trying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tewarig tewarig tewarig left review comments

@Uyadav207 Uyadav207 Uyadav207 left review comments

@pranshuchittora pranshuchittora pranshuchittora requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shivambalwani @Uyadav207 @tewarig @pranshuchittora @flyingcircle