-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore(warnings): Rectification of code by removing all (jsx-A11y) warnings (closed due to Conflict) #45
Conversation
Deploy preview for rne-playground ready! Built with commit cd28e20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this pr comes under #3 .
Awesome work @Uyadav207
but rewriting handleDrawerToggle does not seem to be useful in src/containers/Drawer/index.jsx
No @tewarig I have made new branch for this commit .... they are the previous ones... 😅 Thanks for your concern✌️ |
And it do not comes under #3 because i haven't done any...
Just removed |
still, you are improving the quality of code... 😅 |
@pranshuchittora ok I will try to fix it. |
@pranshuchittora, I got the reason for this conflict... The PR #22 is merged ... before i.e why this pr is causing merge conflict. I will be making changes sooner with the drawer fix.
|
@pranshuchittora, I might need to reopen this. Please Try to merge it ASAP Reason for conflicts
Solution
|
i have made another PR, #47 ... please close this. |
Warnings earlier
alt prop was null for images
jsx-A11y
(span tag to be used for emojis)target= _blank without rel= noopener noreferrer