Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(warnings): Rectification of code by removing all (jsx-A11y) warnings (closed due to Conflict) #45

Closed

Conversation

Uyadav207
Copy link
Contributor

Warnings earlier

  • alt prop was null for images
  • jsx-A11y (span tag to be used for emojis)
  • target= _blank without rel= noopener noreferrer

@netlify
Copy link

netlify bot commented Mar 12, 2021

Deploy preview for rne-playground ready!

Built with commit cd28e20

https://deploy-preview-45--rne-playground.netlify.app

Copy link
Contributor

@tewarig tewarig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this pr comes under #3 .
Awesome work @Uyadav207
but rewriting handleDrawerToggle does not seem to be useful in src/containers/Drawer/index.jsx

@Uyadav207
Copy link
Contributor Author

No @tewarig I have made new branch for this commit .... they are the previous ones... 😅

Thanks for your concern✌️

@Uyadav207
Copy link
Contributor Author

And it do not comes under #3 because i haven't done any...

  • Folder restructuring
  • Styling

Just removed ⚠️ warnings

@tewarig
Copy link
Contributor

tewarig commented Mar 12, 2021

And it do not comes under #3 because i haven't done any...

  • Folder restructuring
  • Styling

Just removed warnings

still, you are improving the quality of code... 😅

@pranshuchittora
Copy link
Member

Resolve the conflicts & clicking on the Playground in the drawer in the mobile more should close the drawer, can you fix that as well ?

Screenshot from 2021-03-12 20-27-21

@Uyadav207
Copy link
Contributor Author

@pranshuchittora ok I will try to fix it.

@Uyadav207
Copy link
Contributor Author

Uyadav207 commented Mar 12, 2021

@pranshuchittora, I got the reason for this conflict... The PR #22 is merged ... before i.e why this pr is causing merge conflict.

I will be making changes sooner with the drawer fix.

  • The conflict occurred with just a single line diff utility 😢

@Uyadav207
Copy link
Contributor Author

@pranshuchittora, I might need to reopen this. Please Try to merge it ASAP

Reason for conflicts

  • The complete stylesheet has been changed. (max 2-3 components).
  • The PR you merge update footer styling - issue#3 #22, has converted all style props to modules.
  • So that's why my PR is conflicting.

Solution

  • Best one : (need to open a new PR)
  • Average : ( Have to match diff ) (Tedious)

@Uyadav207
Copy link
Contributor Author

i have made another PR, #47 ... please close this.

@Uyadav207 Uyadav207 closed this Mar 15, 2021
@Uyadav207 Uyadav207 changed the title Chore(warnings): Rectification of code by removing all (jsx-A11y) warnings Chore(warnings): Rectification of code by removing all (jsx-A11y) warnings (closed due to Conflict) Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants