UI improvement on Home Page #40
Conversation
|
Deploy preview for rne-playground processing. Building with commit fe005f8 https://app.netlify.com/sites/rne-playground/deploys/6055a5b5c5274e00071023c5 |
| </Typography> | ||
| <Typography | ||
| variant="h6" | ||
| style={{ fontWeight: "200", fontStyle: "italic" }} | ||
| className={styles.headerbottom__home} | ||
| > | ||
| with React Native Elements |
There was a problem hiding this comment.
I think it would be good to make it a link which redirects to RNE main repo.
|
@shivambalwani , Great |
I have added CSS modules & removed package-lock.json. Thanks! |
There was a problem hiding this comment.
well, we can also directly add the typewriting effect. instead of using another package. using {useEfect, useState} hooks.
check out this code snippet.
https://gist.githubusercontent.com/abecus/7d20f05a140e99088d9f37517bd594c3/raw/28e0a625691ee655d097fb68cff09f1dd9168ae1/typewriter.js
yes, we can but using this package provides more effects which can be applied quite easily when the user needs. |
|
Typing effect is not required & styles are breaking on the home page (spacing issue) |
Ok, I will remove the typing effect .But i am not able to understand where the styles are breaking 🤔 |
|
https://deploy-preview-40--rne-playground.netlify.app/#/ |
|
@pranshuchittora fixed the style breaking issue and removed the typing effect.plz check. |
package.json
Outdated
| @@ -22,6 +22,7 @@ | |||
| "react-native-web-linear-gradient": "^1.1.1", | |||
| "react-router-dom": "^5.2.0", | |||
| "react-scripts": "3.4.1", | |||
| "react-typewriter": "^0.4.1", | |||
There was a problem hiding this comment.
you did remove the typing effect but forgot to uninstall this package.
npm uninstall react-typewriter
src/pages/home/home.module.css
Outdated
| border: none; | ||
| border-top: 1px solid rgb(226, 226, 226); | ||
| } | ||
| .image{ |
There was a problem hiding this comment.
This is too generic name.
src/pages/home/home.module.css
Outdated
| margin-top: 1rem; | ||
| } | ||
|
|
||
| .line{ |
There was a problem hiding this comment.
This is too generic name.
src/pages/home/home.module.css
Outdated
| } | ||
|
|
||
|
|
||
| .paper{ |
There was a problem hiding this comment.
This is too generic name.
src/pages/home/home.module.css
Outdated
| text-align: center; | ||
| margin-bottom: 2rem; | ||
| } | ||
| .divider{ |
There was a problem hiding this comment.
This is a too generic name.
@pranshuchittora i have fixed the style naming, but the checks are failing. I don't know why? |
|
Pls pull the new changes and resolve the conflicts. |
issue #3 :
Added a typing effect on "Exploring possibilities" .
@pranshuchittora is it good or i need to add some changes to it?