Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix part of #3: created seperate css file for explore page #38

Merged
merged 4 commits into from
Dec 23, 2021
Merged

fix part of #3: created seperate css file for explore page #38

merged 4 commits into from
Dec 23, 2021

Conversation

nlok5923
Copy link
Contributor

Refers: #3

Changes:

  • made seperate css file for explore page.

@netlify
Copy link

netlify bot commented Mar 12, 2021 •
edited
Loading

Deploy preview for rne-playground ready!

Built with commit 661f556

https://deploy-preview-38--rne-playground.netlify.app

tewarig
tewarig reviewed Mar 12, 2021
View reviewed changes
Copy link
Contributor

@tewarig tewarig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.. but this pull request is using a different version of few packages than the one used in this repo.

@nlok5923
Copy link
Contributor Author

@pranshuchittora sir please review this pr.

pranshuchittora
pranshuchittora requested changes Mar 19, 2021
View reviewed changes
Copy link
Member

@pranshuchittora pranshuchittora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls, rename the class names. Position suffix is not intuitive.

@pranshuchittora
Copy link
Member

Pls pull the new changes

@nlok5923
Copy link
Contributor Author

@pranshuchittora sir please review this pr.

@flyingcircle flyingcircle merged commit f579fe3 into react-native-elements:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tewarig tewarig tewarig left review comments

@pranshuchittora pranshuchittora Awaiting requested review from pranshuchittora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nlok5923 @pranshuchittora @tewarig @flyingcircle