Account for dimensions of background pdf #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S.: This would close #11 |
|
There was a bug for size correction in multipage PDFs, which has been fixed by 7ae5885 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally thought it was due to cropping on the reMarkable, but the dimensions of the device simply differ from DIN A4 documents, such that notes on such documents are currently shifted. This PR takes into account the original pdf size and adds a corresponding margin to the right hand side, such that
background.pdfandforeground.pdfhave the same dimensions and notes are properly aligned.Note: This is not affected by cropping, yet currently only tested with Din A4 portrait documents
Example
Additional minor changes
$ID.pdftobackground.pdf, which is more performant for large pdfs (i.e. books).multibackgroundtomultistamp(which accounts for transparency), the foreground and background were flipped (hardly noticeable due to transparent templates). This is also fixed in this PR.