Introduce VirtIONetRaw to allow custom NIC buffer management and used buffer notification suppression #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Arceos PR : arceos-org/arceos#129 |
qwandor
reviewed
Oct 3, 2023
src/device/net/dev_raw.rs
Outdated
| /// | ||
| /// [`fill_buffer_header`]: Self::fill_buffer_header | ||
| pub fn transmit_wait(&mut self, tx_buf: &[u8]) -> Result<usize> { | ||
| let token = unsafe { self.transmit_begin(tx_buf)? }; |
There was a problem hiding this comment.
Please add safety comments for the unsafe blocks, or better, use add_notify_wait_pop to avoid them entirely.
…fication suppression
hky1999
force-pushed
the
cherry-pick-new-netdev
branch
from
80d1652 to
b2adb57
Compare
qwandor
reviewed
Nov 14, 2023
qwandor
reviewed
Nov 14, 2023
src/device/net/dev_raw.rs
Outdated
| } | ||
|
|
||
| /// Whether can receive packet. | ||
| pub fn can_recv(&self) -> bool { |
There was a problem hiding this comment.
Maybe just remove this, poll_receive fills the same purpose.
There was a problem hiding this comment.
you mean peek_used?
Since it was used by ArceOS, so I reserve it, it has been deleted!
There was a problem hiding this comment.
I meant the poll_receive method that you added to VirtIONetRaw, which calls peek_used internally.
I've pushed a commit to keep can_recv on VirtIONet, by calling VirtIONetRAW::peek_used.
qwandor
force-pushed
the
cherry-pick-new-netdev
branch
from
d0e772f to
ceb6ee1
Compare
qwandor
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tiny modifications need to be completed within ArceOS. @equation314