Add ability to change ordering of sections #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated tests to work with new changes
Co-authored-by: Rafael Bardini <[email protected]>
Co-authored-by: Rafael Bardini <[email protected]>
Co-authored-by: Rafael Bardini <[email protected]>
- sections.map return 'null' instead of 'false' for nonexistent section
of resume, e.g. certificates
- body.js -> sections.js
|
(Let me know if better to merge these updates to PR#19 itself. I'd need "write-permission" on it to do so.) |
- add "embeddedLanguageFormatting": "off" to prettier config - re-update resume.js tag formats
rbardini
reviewed
Jan 2, 2024
| @@ -3,5 +3,6 @@ | |||
| "plugins": ["prettier-plugin-organize-imports", "prettier-plugin-packagejson"], | |||
| "printWidth": 120, | |||
| "semi": false, | |||
| "singleQuote": true | |||
| "singleQuote": true, | |||
| "embeddedLanguageFormatting": "off" | |||
There was a problem hiding this comment.
Does anything break if we keep embedded language formatting? I'm wondering why there are so many test snapshot changes. For consistency, I would prefer to not disable it, unless that results in even more changes.
|
Hey just checking what's the status, found some free time as of recent if there's anything more needed to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple commits to update Anish's PR.
Tests succeed === Happy