fix(SideNav): empty padding in banner #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 26f8e56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ PR title follows Conventional Commits specification. |
saurabhdaware
requested review from
chaitanyadeorukhkar,
kamleshchandnani,
anuraghazra,
snitin315 and
tewarig
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 26f8e56:
|
Bundle Size ReportUpdated Components
|
anuraghazra
reviewed
Jan 9, 2025
| @@ -93,6 +93,22 @@ const getL1MenuClassName = ({ | |||
| return ''; | |||
| }; | |||
|
|
|||
| const BannerContainer = styled(BaseBox)((props) => { | |||
| return { | |||
| '&:not(:empty)': { | |||
There was a problem hiding this comment.
wow that's a lot of code i didn't expect. 😆
anuraghazra
previously approved these changes
Jan 9, 2025
anuraghazra
reviewed
Jan 9, 2025
| borderRight: props.theme.border.width.thin, | ||
| borderRightStyle: 'solid', | ||
| borderRightColor: props.theme.colors.surface.border.gray.muted, | ||
| padding: props.theme.spacing[3], |
There was a problem hiding this comment.
ohh good catch. fixed
anuraghazra
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes empty spacing when the component rendered inside banner returns null
https://razorpay.atlassian.net/browse/DSSUP-180
Changes
Additional Information
Component Checklist