Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some exceptions fixed #7

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

andrey-kazakov
Copy link

  1. incompatible encoding exception (US-ASCII vs ASCII-8BIT) was raised in Smpp::Pdu::Base#initialize while reading some PDUs from SMPP bytestream. it's fixed just by String#force_encoding to ASCII-8BIT.
  2. message_id was limited to be integer in Smpp::Tranciever#send_concat_mt. moreover, it's just ruined UDH structure if message_id was >255 and raised an exception if message_id was greater than unicode char range. it's fixed by using object_id of message_id (I don't think that internal ids must be integer anyway; I use hashes in my app, for example) and cutting it down to one octet ( & 0xFF).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant