Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mail extension #16214

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Update mail extension #16214

merged 4 commits into from
Jan 15, 2025

Conversation

ViGeng
Copy link
Contributor

@ViGeng ViGeng commented Jan 8, 2025

Description

  • Add preference for See Recent Mail: unreadonly to show whether only unread messages.

The motivation is that:
When I used the See Recent Mail action, I thought it had bugs since I could not see any emails from my inbox.
When I checked the extension code, I finally realized this command (action) by default only shows unread emails while there is no convenient alternative command to check inbox. (`see mail accounts needs further steps, command -> choose account -> email list).

  • The most simple way is to add a preference which lets users decide what they want to show.
  • There is another way of providing extra command (action) for checking inbox emails, which is to say, Check inboxes.

Screencast

image

Checklist

- add unreadonly for see recent mail action
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: mail Issues related to the mail extension labels Jan 8, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Jan 8, 2025

Thank you for your contribution! 🎉

🔔 @yug2005 @ikupenov @pernielsentikaer @fengtianze @tleo19 @Luk4h @jfkisafk @StevenRCE0 @ridemountainpig you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

@ViGeng
Copy link
Contributor Author

ViGeng commented Jan 8, 2025

I also would ask for opinions regarding the action names. See seems wired; Check would be better, I guess?
If this works for you, please let me know, and I will fix this together in this PR.
image

@pernielsentikaer
Copy link
Collaborator

What do you think @yug2005

@pernielsentikaer pernielsentikaer self-assigned this Jan 8, 2025
@neo773
Copy link
Contributor

neo773 commented Jan 9, 2025

I had the exact same thought when I was trying out this extension so I uninstalled it, so I agree with OP's perspective here.

@pernielsentikaer
Copy link
Collaborator

Makes sense for me to use Search, View, or Check😊

Copy link
Contributor

@yug2005 yug2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the issue with "See" but I guess "View" would work better. Other than that, the change looks good to me.

@ViGeng
Copy link
Contributor Author

ViGeng commented Jan 9, 2025

Okay, let's use view then. :)

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit 8e30123 into raycast:main Jan 15, 2025
2 checks passed
@ViGeng ViGeng deleted the ext/mail branch January 15, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: mail Issues related to the mail extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants