Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Job page add filters #50283

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

Betula-L
Copy link
Contributor

@Betula-L Betula-L commented Feb 6, 2025

Why are these changes needed?

This PR adds some filters for Job page.

  • In Job page, status filter missed Stopped status.
  • In Job page, it should add Submission ID filter, while submission id is meaningful for user since it's the only id could be assigned by sdk, i.e. submit_job(job_id="actual_is_submission_id")
    image

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests

Signed-off-by: luhualin <[email protected]>
@Betula-L Betula-L changed the title job page add filter [Dashboard] Job page add filters Feb 6, 2025
@jcotant1 jcotant1 added the dashboard Issues specific to the Ray Dashboard label Feb 6, 2025
@pcmoritz pcmoritz added the go add ONLY when ready to merge, run all tests label Feb 9, 2025
Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!

@pcmoritz pcmoritz enabled auto-merge (squash) February 9, 2025 01:23
@pcmoritz pcmoritz merged commit 1acae9c into ray-project:master Feb 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Issues specific to the Ray Dashboard go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants