Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update services.py: remove one duplicated params: `--runtime-env-agen… #49678

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

hefeiyun
Copy link
Contributor

@hefeiyun hefeiyun commented Jan 7, 2025

there are two same param: --runtime-env-agent-port, remove one.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jcotant1 jcotant1 added the core Issues that should be addressed in Ray Core label Jan 9, 2025
…t-port`

there are two same param: --runtime-env-agent-port,
remove one.

Signed-off-by: hefeiyun <[email protected]>
@pcmoritz
Copy link
Contributor

pcmoritz commented Feb 9, 2025

Thanks for fixing this!

@pcmoritz pcmoritz enabled auto-merge (squash) February 9, 2025 02:06
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Feb 9, 2025
@pcmoritz pcmoritz merged commit 37caeac into ray-project:master Feb 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants