[py312] Skip tests+examples for Tune dependencies that do not support py312

.buildkite/ml.rayci.yml

@@ -164,26 +164,6 @@ steps:
         --only-tags minimal
     depends_on: [ "minbuild-ml", "forge" ]
 
-  - label: ":train: ml: tune multinode tests"
-    tags: tune
-    instance_type: medium
-    commands:
-      - bazel run //ci/ray_ci:build_in_docker -- docker
-        --platform cpu --image-type ray --canonical-tag multinode
-      - python ./ci/build/build-multinode-image.py rayproject/ray:multinode rayproject/ray:multinode
-      - bazel run //ci/ray_ci:test_in_docker -- //python/ray/tune/... ml 
-        --only-tags multinode
-        --test-env=RAY_HAS_SSH=1
-        --test-env=RAY_DOCKER_IMAGE=rayproject/ray:multinode
-        --test-env=RAY_TEMPDIR="/ray-mount"
-        --test-env=RAY_HOSTDIR="$${RAYCI_CHECKOUT_DIR}"
-        --test-env=RAY_TESTHOST="rayci.localhost"
-    depends_on: 
-      - manylinux
-      - forge
-      - raycpubase
-      - mlbuild
-
   - label: ":train: ml: doc tests"
     tags: 
       - train

ci/ci.sh

@@ -109,10 +109,6 @@ compile_pip_dependencies() {
     "${WORKSPACE_DIR}/python/requirements/security-requirements.txt" \
     "${WORKSPACE_DIR}/python/requirements/anyscale-requirements.txt"
 
-  # Remove some pins from upstream dependencies:
-  # ray, xgboost-ray, lightgbm-ray, tune-sklearn
-  sed -i "/^ray==/d;/^xgboost-ray==/d;/^lightgbm-ray==/d;/^tune-sklearn==/d" "${WORKSPACE_DIR}/python/$TARGET"
-
   # Delete local installation
   sed -i "/@ file/d" "${WORKSPACE_DIR}/python/$TARGET"
 

doc/source/conf.py

@@ -212,7 +212,6 @@ def __init__(self, version: str):
         "https://mvnrepository.com/artifact/*",  # working but somehow not with linkcheck
         # This should be fixed -- is temporal the successor of cadence? Do the examples need to be updated?
         "https://github.com/serverlessworkflow/specification/blob/main/comparisons/comparison-cadence.md",
-        # TODO(richardliaw): The following probably needs to be fixed in the tune_sklearn package
         "https://www.oracle.com/java/technologies/javase-jdk15-downloads.html",  # forbidden for client
         "https://speakerdeck.com/*",  # forbidden for bots
         r"https://huggingface.co/*",  # seems to be flaky

doc/source/tune/examples/BUILD

@@ -22,6 +22,8 @@ py_test_run_all_notebooks(
         "tune-xgboost.ipynb",
         "pbt_transformers.ipynb",  # Transformers uses legacy Tune APIs.
         "horovod_simple.ipynb",  # CI do not have Horovod
+        "tune-aim.ipynb",  # CI does not have `aim`
+        "bohb_example.ipynb",  # CI does not have bohb requirements
    ],
     tags = [
         "exclusive",

python/ray/air/tests/test_air_usage.py

@@ -18,7 +18,6 @@
 from ray.tune.callback import Callback
 from ray.tune.experiment.experiment import Experiment
 from ray.tune.logger import LoggerCallback
-from ray.tune.logger.aim import AimLoggerCallback
 from ray.tune.utils.callback import DEFAULT_CALLBACK_CLASSES
 
 
@@ -113,7 +112,6 @@ class _CustomCallback(Callback):
     wandb.WandbLoggerCallback,
     mlflow.MLflowLoggerCallback,
     comet.CometLoggerCallback,
-    AimLoggerCallback,
     _CustomLoggerCallback,
     _CustomLoggerCallback,
     _CustomCallback,
@@ -152,7 +150,6 @@ def test_tag_setup_mlflow(mock_record, monkeypatch):
                 "WandbLoggerCallback": 1,
                 "MLflowLoggerCallback": 1,
                 "CometLoggerCallback": 1,
-                "AimLoggerCallback": 1,
                 "CustomLoggerCallback": 2,
                 "CustomCallback": 1,
             },

python/ray/tune/BUILD

@@ -159,14 +159,6 @@ py_test(
     tags = ["team:ml"],
 )
 
-py_test(
-    name = "test_multinode_sync",
-    size = "large",
-    srcs = ["tests/test_multinode_sync.py"],
-    deps = [":tune_lib"],
-    tags = ["team:ml", "multinode"],
-)
-
 py_test(
     name = "test_progress_reporter",
     size = "medium",

python/ray/tune/examples/bohb_example.py

@@ -50,6 +50,13 @@ def load_checkpoint(self, checkpoint_dir):
 
 
 if __name__ == "__main__":
+    import sys
+
+    import pytest
+
+    if sys.version_info >= (3, 12):
+        pytest.fail("TuneBOHB is not compatible with Python 3.12")
+
     ray.init(num_cpus=8)
 
     config = {

python/ray/tune/tests/conftest.py

@@ -29,3 +29,26 @@ def mock_s3_bucket_uri():
         logging.getLogger("werkzeug").setLevel(logging.WARNING)
         yield s3_uri
         logging.getLogger("werkzeug").setLevel(logging.INFO)
+
+
+# Register the custom mark
+def pytest_configure(config):
+    config.addinivalue_line(
+        "markers",
+        "failif(condition, *, reason=...): Fail the test if the condition is true",
+    )
+
+
+# Define the custom mark behavior
+@pytest.hookimpl(tryfirst=True)
+def pytest_runtest_setup(item):
+    fail_marker = item.get_closest_marker("failif")
+    if not fail_marker:
+        return
+
+    condition = fail_marker.args[0]
+    reason = fail_marker.kwargs.get(
+        "reason", "Test failed due to failif condition being True."
+    )
+    if condition:
+        pytest.fail(reason, pytrace=False)

python/ray/tune/tests/test_convergence.py

@@ -1,4 +1,5 @@
 import math
+import sys
 import unittest
 
 import numpy as np
@@ -79,6 +80,9 @@ def testConvergenceBayesOpt(self):
         assert len(analysis.trials) < 50
         assert math.isclose(analysis.best_config["x"], 0, abs_tol=1e-5)
 
+    @pytest.mark.skipif(
+        sys.version_info >= (3, 12), reason="HEBO doesn't support py312"
+    )
     def testConvergenceHEBO(self):
         from ray.tune.search.hebo import HEBOSearch
 
@@ -137,6 +141,4 @@ def testConvergenceZoopt(self):
 
 
 if __name__ == "__main__":
-    import sys
-
     sys.exit(pytest.main(["-v", __file__]))

python/ray/tune/tests/test_logger.py

@@ -3,13 +3,15 @@
 import json
 import os
 import shutil
+import sys
 import tempfile
 import unittest
 from dataclasses import dataclass
 from pathlib import Path
 from typing import Optional
 
 import numpy as np
+import pytest
 
 import ray
 from ray.air.constants import (
@@ -295,6 +297,7 @@ def testBadTBX(self):
         assert "INFO" in cm.output[0]
 
 
+@pytest.mark.skipif(sys.version_info >= (3, 12), reason="Aim doesn't support py312")
 class AimLoggerSuite(unittest.TestCase):
     """Test Aim integration."""