Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accelerators.rst #45549

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Update accelerators.rst #45549

merged 3 commits into from
Jul 16, 2024

Conversation

anyscalesam
Copy link
Contributor

Small update to link to AWS examples gallery.

Done.

Done.

Why are these changes needed?

Adding a cross-link to AWS EKS example for Inferentia Ray Serve and various popular OSS LLM models.

Related issue number

None.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Small update to link to AWS examples gallery.

Signed-off-by: Samuel Chan <[email protected]>
@anyscalesam anyscalesam self-assigned this May 24, 2024
@anyscalesam anyscalesam requested a review from a team as a code owner May 24, 2024 23:22
@@ -85,6 +85,8 @@ If you need to, you can :ref:`override <specify-node-resources>` this.
For example, ``NEURON_RT_VISIBLE_CORES=1,3 ray start --head --resources='{"neuron_cores": 2}'``
lets Ray only see devices 1 and 3.

Amazon also maintains a very good documentation and examples gallery for getting started on Ray on Neuron with the help of EKS as a orchestration substrate. You can find that here: `https://awslabs.github.io/data-on-eks/docs/category/inference-on-eks` <https://awslabs.github.io/data-on-eks/docs/category/inference-on-eks>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; leave it to @angelinalg for the content

nit: break long line into small chunk

@anyscalesam anyscalesam enabled auto-merge (squash) June 15, 2024 19:07
@github-actions github-actions bot disabled auto-merge June 15, 2024 19:07
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jun 15, 2024
@anyscalesam anyscalesam added core Issues that should be addressed in Ray Core core-hardware Hardware support in Ray core: e.g. accelerators labels Jul 15, 2024
@anyscalesam anyscalesam merged commit c73ac91 into master Jul 16, 2024
8 checks passed
@anyscalesam anyscalesam deleted the anyscalesam-patch-3 branch July 16, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core core-hardware Hardware support in Ray core: e.g. accelerators go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants