[ci][microcheck] include step id from all step job flavors #45403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will also allow dag tests run on both cpu+gpu test jobs @stephanie-wang |
aslonnie
approved these changes
May 17, 2024
@MicroCheck //release:test_config //release:invalid_test Signed-off-by: can <[email protected]>
Signed-off-by: can <[email protected]>
Signed-off-by: can <[email protected]>
Signed-off-by: can <[email protected]>
can-anyscale
added a commit
that referenced
this pull request
May 23, 2024
…45403)" This reverts commit e0ac723. Signed-off-by: can <[email protected]>
can-anyscale
added a commit
that referenced
this pull request
May 23, 2024
…45514) Reverts #45403. This seems like not a good idea. Run between different test flavors do not provide a lot of signals, but there are a lot of those so it is notably more expensive. Test: - https://buildkite.com/ray-project/microcheck/builds/488 Signed-off-by: can <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI have a lot of different step 'flavor' that run the same tests (e.g. data6, data15, etc.). Currently microcheck randomly pick one of the step flavor given a test. This PR makes sure that it include all possible step flavors of that test.
Test: