Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in README and in ray.data.Dataset #45345

Merged
merged 6 commits into from
Jul 2, 2024

Conversation

SumanthRH
Copy link
Contributor

Why are these changes needed?

This is massive PR to fix two outdated documentation links.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: SumanthRH <[email protected]>
@anyscalesam anyscalesam enabled auto-merge (squash) May 29, 2024 05:53
@github-actions github-actions bot disabled auto-merge May 29, 2024 05:53
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label May 29, 2024
@anyscalesam anyscalesam self-assigned this May 29, 2024
@anyscalesam anyscalesam added P0 Issues that should be fixed in short order docs An issue or change related to documentation data Ray Data-related issues labels May 29, 2024
@anyscalesam anyscalesam added P2 Important issue, but not time-critical and removed P0 Issues that should be fixed in short order labels Jun 24, 2024
@raulchen raulchen enabled auto-merge (squash) June 25, 2024 23:51
@anyscalesam
Copy link
Contributor

@SumanthRH cool to update branch and merge this in?

@github-actions github-actions bot disabled auto-merge June 29, 2024 01:53
@SumanthRH
Copy link
Contributor Author

@anyscalesam looks like this still needs an approval from one of the code owners

Copy link
Member

@bveeramani bveeramani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bveeramani bveeramani merged commit 842c2ed into ray-project:master Jul 2, 2024
6 checks passed
@SumanthRH SumanthRH deleted the fix-broken-links branch July 2, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Ray Data-related issues docs An issue or change related to documentation go add ONLY when ready to merge, run all tests P2 Important issue, but not time-critical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants