Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Rework Serve example page #45231

Merged
merged 2 commits into from
May 28, 2024

Conversation

peytondmurray
Copy link
Contributor

Why are these changes needed?

This PR changes the grouping of the Serve examples page, and allows the grouping of any example page to be configurable by changing the value of the groupby key in examples.yml.

Related issue number

Closes #44457.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@peytondmurray peytondmurray requested a review from angelinalg May 10, 2024 16:22
@peytondmurray peytondmurray marked this pull request as ready for review May 10, 2024 16:23
@peytondmurray peytondmurray removed the request for review from angelinalg May 10, 2024 16:23
@peytondmurray peytondmurray added serve Ray Serve Related Issue docs An issue or change related to documentation labels May 10, 2024
doc/source/train/examples.yml Outdated Show resolved Hide resolved
@peytondmurray peytondmurray force-pushed the docs-rework-serve-examples branch from abe9071 to 3fc3568 Compare May 27, 2024 23:11
Co-authored-by: angelinalg <[email protected]>
Signed-off-by: Peyton Murray <[email protected]>
@peytondmurray peytondmurray force-pushed the docs-rework-serve-examples branch from 3fc3568 to e51fd11 Compare May 27, 2024 23:17
@edoakes edoakes enabled auto-merge (squash) May 28, 2024 16:55
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label May 28, 2024
@edoakes edoakes merged commit fa0e6d7 into ray-project:master May 28, 2024
8 checks passed
@peytondmurray peytondmurray deleted the docs-rework-serve-examples branch May 29, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation go add ONLY when ready to merge, run all tests serve Ray Serve Related Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ray Serve docs - reorg Examples page
4 participants