RISC-V __mulsf3: handle exponent increase due to rounding #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, this needs to also check overflow after exponent adjustment. I'll add another testcase |
Wren6991
force-pushed
the
fix-mulsf3-exponent
branch
from
a955473 to
0cc6f37
Compare
Wren6991
force-pushed
the
fix-mulsf3-exponent
branch
from
0cc6f37 to
ce517af
Compare
|
...and do that without making underflow slower. Ready for review now |
kilograham
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally reported by @Panda381. I thought this case was unreachable for multiply, but it's unfortunately just rare. This costs one cycle.