feat: Support setting a sleep timer #99
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronleopold
force-pushed
the
sleep-timer
branch
from
0f4e94b to
5371672
Compare
aaronleopold
force-pushed
the
sleep-timer
branch
from
5371672 to
4ae5edc
Compare
aaronleopold
commented
Feb 19, 2025
Comment on lines
+100
to
+111
| commandCenter.enableLanguageOptionCommand.isEnabled = true | ||
| commandCenter.enableLanguageOptionCommand.addTarget { [unowned self] event in | ||
| // TODO: get a value somehow? | ||
| setSleepTimer(minutes: 30) | ||
| return .success | ||
| } | ||
|
|
||
| commandCenter.disableLanguageOptionCommand.isEnabled = true | ||
| commandCenter.disableLanguageOptionCommand.addTarget { [unowned self] event in | ||
| cancelSleepTimer() | ||
| return .success | ||
| } |
There was a problem hiding this comment.
I don't think these are actually needed, left it in just in case I should have something here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #98
Opening as a draft because I am not a Swift dev, so I likely used bad patterns. However, the timer is functional in its current state. Happy to iterate as needed to get it to better Swift standards!
As a side note, I imagine we could pull some of this in order to also add this functionality to rasmuslos/ShelfPlayer#193
Without timer set
With timer set