Skip to content

Commit

Permalink
Improve code
Browse files Browse the repository at this point in the history
  • Loading branch information
@rasmuslos
rasmuslos committed Nov 20, 2024
1 parent f0e9e0c commit 93ceb65
Show file tree
Hide file tree
Showing 21 changed files with 594 additions and 506 deletions.
45 changes: 43 additions & 2 deletions AmpFin.xcodeproj/project.pbxproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@
3A4A3B872BDBEB0B00A90835 /* Handler+Search.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3A4A3B862BDBEB0B00A90835 /* Handler+Search.swift */; };
3A4A3B892BDCDF5300A90835 /* Handler+Add.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3A4A3B882BDCDF5300A90835 /* Handler+Add.swift */; };
3A4A3B8B2BDCE27600A90835 /* AddMediaHandler.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3A4A3B8A2BDCE27600A90835 /* AddMediaHandler.swift */; };
3A50D4652CE8AD9300E368DF /* LoginViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3A50D4642CE8AD8F00E368DF /* LoginViewModel.swift */; };
3A50D4682CE8ADE700E368DF /* WelcomeView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3A50D4672CE8ADE700E368DF /* WelcomeView.swift */; };
3A50F31A2C6F599A00A09ECB /* UIApplication+Tap.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3A50F3192C6F599A00A09ECB /* UIApplication+Tap.swift */; };
3A5515EE2BC3E1CA00B922D7 /* Sidebar.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3A5515ED2BC3E1CA00B922D7 /* Sidebar.swift */; };
3A5515F22BC435A200B922D7 /* Defaults in Frameworks */ = {isa = PBXBuildFile; productRef = 3A5515F12BC435A200B922D7 /* Defaults */; };
Expand Down Expand Up @@ -88,6 +90,8 @@
3A98A0322AABA3DF00EA84CF /* ArtistLoadView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3A98A0312AABA3DF00EA84CF /* ArtistLoadView.swift */; };
3AA0AFAA2BE540500084B7A1 /* NowPlaying.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3AA0AFA92BE540500084B7A1 /* NowPlaying.swift */; };
3AA0AFAC2BE545CA0084B7A1 /* XRTabs.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3AA0AFAB2BE545CA0084B7A1 /* XRTabs.swift */; };
3AA803E72CE8B05D0048329B /* LoginFormView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3AA803E62CE8B0550048329B /* LoginFormView.swift */; };
3AA803EA2CE8B3390048329B /* FluidGradient in Frameworks */ = {isa = PBXBuildFile; productRef = 3AA803E92CE8B3390048329B /* FluidGradient */; };
3AA94F8E2BB02E130012E731 /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = 3A2657EF2BA340EC000C62E3 /* PrivacyInfo.xcprivacy */; };
3AA94F912BB02E230012E731 /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = 3A2657F02BA34113000C62E3 /* PrivacyInfo.xcprivacy */; };
3AA98A662BDF9FC500C52D27 /* Intents.intentdefinition in Sources */ = {isa = PBXBuildFile; fileRef = 3AA98A652BDF9FC500C52D27 /* Intents.intentdefinition */; };
Expand All @@ -101,6 +105,7 @@
3AAF0DEC2B4960EF0032DEFF /* Intents.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 3A442C092B485E56008FECE2 /* Intents.framework */; };
3AAF0DEF2B4960EF0032DEFF /* IntentHandler.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3AAF0DEE2B4960EF0032DEFF /* IntentHandler.swift */; };
3AAF0DF32B4960EF0032DEFF /* Siri Extension.appex in Embed Foundation Extensions */ = {isa = PBXBuildFile; fileRef = 3AAF0DEB2B4960EF0032DEFF /* Siri Extension.appex */; platformFilters = (ios, maccatalyst, ); settings = {ATTRIBUTES = (RemoveHeadersOnCopy, ); }; };
3AB791CF2CEE572D001E3F00 /* UnavailableWrapper.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3AB791CE2CEE572C001E3F00 /* UnavailableWrapper.swift */; };
3ABF77E52C87452C0006ADBC /* CustomHeaderEditView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3ABF77E42C87452C0006ADBC /* CustomHeaderEditView.swift */; };
3AC65BD92BE222CD00448D5E /* TrackGrid.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3AC65BD82BE222CD00448D5E /* TrackGrid.swift */; };
3AC65BDB2BE224D500448D5E /* Array+Repeat.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3AC65BDA2BE224D500448D5E /* Array+Repeat.swift */; };
Expand Down Expand Up @@ -198,6 +203,8 @@
3A4A3B862BDBEB0B00A90835 /* Handler+Search.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Handler+Search.swift"; sourceTree = "<group>"; };
3A4A3B882BDCDF5300A90835 /* Handler+Add.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Handler+Add.swift"; sourceTree = "<group>"; };
3A4A3B8A2BDCE27600A90835 /* AddMediaHandler.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AddMediaHandler.swift; sourceTree = "<group>"; };
3A50D4642CE8AD8F00E368DF /* LoginViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LoginViewModel.swift; sourceTree = "<group>"; };
3A50D4672CE8ADE700E368DF /* WelcomeView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = WelcomeView.swift; sourceTree = "<group>"; };
3A50F3192C6F599A00A09ECB /* UIApplication+Tap.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UIApplication+Tap.swift"; sourceTree = "<group>"; };
3A5515ED2BC3E1CA00B922D7 /* Sidebar.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Sidebar.swift; sourceTree = "<group>"; };
3A5515F32BC4391300B922D7 /* Sidebar+Links.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Sidebar+Links.swift"; sourceTree = "<group>"; };
Expand Down Expand Up @@ -233,6 +240,7 @@
3A98A0312AABA3DF00EA84CF /* ArtistLoadView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ArtistLoadView.swift; sourceTree = "<group>"; };
3AA0AFA92BE540500084B7A1 /* NowPlaying.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NowPlaying.swift; sourceTree = "<group>"; };
3AA0AFAB2BE545CA0084B7A1 /* XRTabs.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = XRTabs.swift; sourceTree = "<group>"; };
3AA803E62CE8B0550048329B /* LoginFormView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LoginFormView.swift; sourceTree = "<group>"; };
3AA98A642BDF9FC500C52D27 /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.intentdefinition; name = Base; path = Base.lproj/Intents.intentdefinition; sourceTree = "<group>"; };
3AA98A682BDF9FCA00C52D27 /* en */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = en; path = en.lproj/Intents.strings; sourceTree = "<group>"; };
3AA98A6A2BDF9FCA00C52D27 /* de */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = de; path = de.lproj/Intents.strings; sourceTree = "<group>"; };
Expand All @@ -250,6 +258,7 @@
3AB697A12B386B20009000DD /* LibraryDataProvider.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LibraryDataProvider.swift; sourceTree = "<group>"; };
3AB697A22B386B20009000DD /* MockLibraryDataProvider.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockLibraryDataProvider.swift; sourceTree = "<group>"; };
3AB697A32B386B20009000DD /* OfflineLibraryDataProvider.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = OfflineLibraryDataProvider.swift; sourceTree = "<group>"; };
3AB791CE2CEE572C001E3F00 /* UnavailableWrapper.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UnavailableWrapper.swift; sourceTree = "<group>"; };
3ABAFCAA2AA7D6C40011BFD6 /* AmpFin.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = AmpFin.app; sourceTree = BUILT_PRODUCTS_DIR; };
3ABF77E42C87452C0006ADBC /* CustomHeaderEditView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CustomHeaderEditView.swift; sourceTree = "<group>"; };
3AC65BD82BE222CD00448D5E /* TrackGrid.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TrackGrid.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -289,6 +298,7 @@
buildActionMask = 2147483647;
files = (
3A2146E32BF4D015001DA9E2 /* AmpFinKit in Frameworks */,
3AA803EA2CE8B3390048329B /* FluidGradient in Frameworks */,
3AE1B0E32ABCDCE80052C8AA /* NukeUI in Frameworks */,
3A3A36FA2C7CAE7D001A29FD /* RFKit in Frameworks */,
3A2146E52BF4D019001DA9E2 /* AFPlayback in Frameworks */,
Expand All @@ -315,6 +325,7 @@
3A150F5F2BC688DA006E29E2 /* Common */ = {
isa = PBXGroup;
children = (
3AB791CE2CEE572C001E3F00 /* UnavailableWrapper.swift */,
3A98A02F2AABA37B00EA84CF /* ErrorView.swift */,
3A98A02D2AABA36600EA84CF /* LoadingView.swift */,
);
Expand Down Expand Up @@ -382,6 +393,18 @@
path = Artist;
sourceTree = "<group>";
};
3A50D4632CE8AD7500E368DF /* Login */ = {
isa = PBXGroup;
children = (
3AA803E62CE8B0550048329B /* LoginFormView.swift */,
EAB1E6C42CA69AF20094D8EF /* LoginQuickConnectView.swift */,
3A50D4642CE8AD8F00E368DF /* LoginViewModel.swift */,
3AEB32292AA7EC3C00853210 /* LoginView.swift */,
3A50D4672CE8ADE700E368DF /* WelcomeView.swift */,
);
path = Login;
sourceTree = "<group>";
};
3A5515EB2BC3E0C100B922D7 /* Sidebar */ = {
isa = PBXGroup;
children = (
Expand Down Expand Up @@ -619,6 +642,7 @@
3ADE8E9E2AA93CC4009826A3 /* Album */,
3A2B28EB2B43737200DF9731 /* Playlist */,
3A111B662C81FC9E001BED19 /* Library */,
3A50D4632CE8AD7500E368DF /* Login */,
3AEB32282AA7EC3C00853210 /* Account */,
3A150F602BC68FD2006E29E2 /* Collections */,
3A5515F52BC4471600B922D7 /* Navigation */,
Expand All @@ -640,10 +664,8 @@
3AEB32282AA7EC3C00853210 /* Account */ = {
isa = PBXGroup;
children = (
3AEB32292AA7EC3C00853210 /* LoginView.swift */,
3A3AF1A52AC4523600811D7D /* AccountSheet.swift */,
3ABF77E42C87452C0006ADBC /* CustomHeaderEditView.swift */,
EAB1E6C42CA69AF20094D8EF /* LoginQuickConnectView.swift */,
3A36ED3E2BE8EDD200AECE9C /* Account+Remote.swift */,
);
path = Account;
Expand Down Expand Up @@ -695,6 +717,7 @@
3A2146E22BF4D015001DA9E2 /* AmpFinKit */,
3A2146E42BF4D019001DA9E2 /* AFPlayback */,
3A3A36F92C7CAE7D001A29FD /* RFKit */,
3AA803E92CE8B3390048329B /* FluidGradient */,
);
productName = JellyfinMusic;
productReference = 3ABAFCAA2AA7D6C40011BFD6 /* AmpFin.app */;
Expand Down Expand Up @@ -732,6 +755,7 @@
3AE1B0DD2ABCDCE80052C8AA /* XCRemoteSwiftPackageReference "Nuke" */,
3A5515F02BC435A200B922D7 /* XCRemoteSwiftPackageReference "Defaults" */,
3A3A36F82C7CAE7D001A29FD /* XCRemoteSwiftPackageReference "RFKit" */,
3AA803E82CE8B3390048329B /* XCRemoteSwiftPackageReference "FluidGradient" */,
);
productRefGroup = 3ABAFCAB2AA7D6C40011BFD6 /* Products */;
projectDirPath = "";
Expand Down Expand Up @@ -843,6 +867,7 @@
3A2B28E52B433C8A00DF9731 /* PlaylistsView.swift in Sources */,
3AF3BA922C52358800C96E1F /* DisplayContext.swift in Sources */,
3A8850602AA90CA200456DDD /* AlbumGrid.swift in Sources */,
3A50D4682CE8ADE700E368DF /* WelcomeView.swift in Sources */,
3A98A02E2AABA36600EA84CF /* LoadingView.swift in Sources */,
3AAC768D2B02C68600E337C1 /* ItemImage.swift in Sources */,
3A1CBC192B0D284200855A70 /* Navigation.swift in Sources */,
Expand All @@ -857,6 +882,7 @@
3A8850622AA90D1200456DDD /* AlbumsView.swift in Sources */,
3AA0AFAC2BE545CA0084B7A1 /* XRTabs.swift in Sources */,
3A7939012B387851001B3B3D /* MockLibraryDataProvider.swift in Sources */,
3AB791CF2CEE572D001E3F00 /* UnavailableWrapper.swift in Sources */,
3AE1B0DC2ABCDA0A0052C8AA /* AppDelegate.swift in Sources */,
3A2B29002B43819400DF9731 /* PlaylistView+Toolbar.swift in Sources */,
3AAE1B532BC593EB00FD0200 /* RegularView.swift in Sources */,
Expand Down Expand Up @@ -910,13 +936,15 @@
3A3DA66B2AAB2DDA0091211A /* ArtistView.swift in Sources */,
3A3DA6682AAB2CDA0091211A /* ArtistListRow.swift in Sources */,
3A8B99402AAA0085004AAA7B /* Controls.swift in Sources */,
3AA803E72CE8B05D0048329B /* LoginFormView.swift in Sources */,
3A6F50AB2AACABEB00FC8A29 /* AlbumListRow.swift in Sources */,
3A8B993E2AA9FE02004AAA7B /* Title.swift in Sources */,
3A3501022C52CBF600ED1C27 /* LyricsSheet.swift in Sources */,
3AA98A662BDF9FC500C52D27 /* Intents.intentdefinition in Sources */,
3A2B28E82B43422800DF9731 /* PlaylistsList.swift in Sources */,
3A3DA6642AAB2BC10091211A /* ArtistList.swift in Sources */,
3A07CD932B4401BE00F9AB19 /* PlaylistAddSheet.swift in Sources */,
3A50D4652CE8AD9300E368DF /* LoginViewModel.swift in Sources */,
3A8850642AA90E4600456DDD /* AlbumView.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
Expand Down Expand Up @@ -1282,6 +1310,14 @@
minimumVersion = 8.2.0;
};
};
3AA803E82CE8B3390048329B /* XCRemoteSwiftPackageReference "FluidGradient" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/Cindori/FluidGradient.git";
requirement = {
kind = upToNextMajorVersion;
minimumVersion = 1.0.0;
};
};
3AE1B0DD2ABCDCE80052C8AA /* XCRemoteSwiftPackageReference "Nuke" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/kean/Nuke.git";
Expand Down Expand Up @@ -1315,6 +1351,11 @@
package = 3A5515F02BC435A200B922D7 /* XCRemoteSwiftPackageReference "Defaults" */;
productName = Defaults;
};
3AA803E92CE8B3390048329B /* FluidGradient */ = {
isa = XCSwiftPackageProductDependency;
package = 3AA803E82CE8B3390048329B /* XCRemoteSwiftPackageReference "FluidGradient" */;
productName = FluidGradient;
};
3AE1B0E22ABCDCE80052C8AA /* NukeUI */ = {
isa = XCSwiftPackageProductDependency;
package = 3AE1B0DD2ABCDCE80052C8AA /* XCRemoteSwiftPackageReference "Nuke" */;
Expand Down
9 changes: 9 additions & 0 deletions AmpFin.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@
"version" : "8.2.0"
}
},
{
"identity" : "fluidgradient",
"kind" : "remoteSourceControl",
"location" : "https://github.com/Cindori/FluidGradient.git",
"state" : {
"revision" : "9ddda4cf23671ef0228e88681ec6210cb3e0d7f7",
"version" : "1.0.0"
}
},
{
"identity" : "nuke",
"kind" : "remoteSourceControl",
Expand Down
38 changes: 22 additions & 16 deletions AmpFinKit/Sources/AFNetwork/Methods/JellyfinClient+QuickConnect.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,35 +3,41 @@
// AmpFin
//
// Created by Daniel Cuevas on 9/28/24 at 1:39 AM.
//

//

import Foundation

public extension JellyfinClient {
func checkIfQuickConnectIsAvailable() async throws -> Bool {
if !JellyfinClient.shared.supports(.quickConnect) {
return false
var quickConnectAvailable: Bool {
get async {
guard supports(.quickConnect) else {
return false
}

return (try? await request(ClientRequest<Bool>(path: "/QuickConnect/Enabled", method: "GET"))) ?? false
}
let response = try await request(ClientRequest<Bool>(path: "/QuickConnect/Enabled", method: "GET"))

return response
}

func initiateQuickConnect() async throws -> (String, String) {
let response = try await request(ClientRequest<QuickConnectResponse>(path: "/QuickConnect/initiate", method: "POST"))
return (response.Code, response.Secret)
}

func verifyQuickConnect(secret: String) async -> Bool {
guard let response = try? await request(ClientRequest<QuickConnectResponse>(path: "/QuickConnect/Connect", method: "GET", query: [
URLQueryItem(name: "Secret", value: secret),
])) else {
return false
}

return (
response.Code,
response.Secret
)
return response.Authenticated
}

func verifyQuickConnect(secret: String) async throws -> Bool {
let response = try await request(ClientRequest<QuickConnectResponse>(path: "/QuickConnect/Connect", method: "GET", query:[
URLQueryItem(name: "Secret", value: secret)
func login(secret: String) async throws -> (String, String) {
let response = try await request(ClientRequest<AuthenticateByNameOrQuickConnectResponse>(path: "Users/AuthenticateWithQuickConnect", method: "POST", body: [
"Secret": secret
]))

return response.Authenticated
return (response.AccessToken, response.User.Id)
}
}
8 changes: 0 additions & 8 deletions AmpFinKit/Sources/AFNetwork/Methods/JellyfinClient+User.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,6 @@ public extension JellyfinClient {
return (response.AccessToken, response.User.Id)
}

func loginWithQuickConnect(secret: String) async throws -> (String, String) {
let response = try await request(ClientRequest<AuthenticateByNameOrQuickConnectResponse>(path: "Users/AuthenticateWithQuickConnect", method: "POST", body: [
"Secret": secret
]))

return (response.AccessToken, response.User.Id)
}

func userData() async throws -> (String, String, String, Bool) {
let response = try await request(ClientRequest<UserDataResponse>(path: "/Users/\(userId)", method: "GET"))

Expand Down
11 changes: 2 additions & 9 deletions Multiplatform/Account/AccountSheet.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,8 @@ internal struct AccountSheet: View {
@State private var serverVersion: String?
@State private var downloads: [Track]? = nil

@State private var navigationPath = NavigationPath()

var body: some View {
NavigationStack(path: $navigationPath) {
NavigationStack {
List {
HStack(spacing: 0) {
ItemImage(cover: Cover(
Expand Down Expand Up @@ -55,7 +53,7 @@ internal struct AccountSheet: View {
Label("account.settings", systemImage: "gear")
}

NavigationLink(value: "") {
NavigationLink(destination: CustomHeaderEditView()) {
Label("login.customHTTPHeaders", systemImage: "network.badge.shield.half.filled")
}
}
Expand Down Expand Up @@ -138,11 +136,6 @@ internal struct AccountSheet: View {
}
.navigationTitle("account.title")
.navigationBarTitleDisplayMode(.inline)
.navigationDestination(for: String.self) { _ in
CustomHeaderEditView(backButtonVisible: false) {
navigationPath.removeLast()
}
}
.task {
do {
serverVersion = try? await JellyfinClient.shared.serverVersion()
Expand Down
17 changes: 1 addition & 16 deletions Multiplatform/Account/CustomHeaderEditView.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ import AmpFinKit
internal struct CustomHeaderEditView: View {
@State private var current = JellyfinClient.shared.customHTTPHeaders

let backButtonVisible: Bool
let dismiss: (() -> Void)

private var trimmed: [JellyfinClient.CustomHTTPHeader] {
current.filter { !$0.key.isEmpty && !$0.value.isEmpty }
}
Expand Down Expand Up @@ -41,17 +38,6 @@ internal struct CustomHeaderEditView: View {
.navigationTitle("login.customHTTPHeaders")
.navigationBarTitleDisplayMode(.inline)
.toolbar {
if backButtonVisible {
ToolbarItem(placement: .topBarLeading) {
Button {
dismiss()
} label: {
Label("done", systemImage: "chevron.left")
.labelStyle(.iconOnly)
}
}
}

ToolbarItemGroup(placement: .topBarTrailing) {
Button {
current.append(.init(key: "", value: ""))
Expand All @@ -62,7 +48,6 @@ internal struct CustomHeaderEditView: View {

Button {
JellyfinClient.shared.customHTTPHeaders = trimmed
dismiss()
} label: {
Label("login.customHTTPHeaders.save", systemImage: "checkmark")
.labelStyle(.titleOnly)
Expand All @@ -79,6 +64,6 @@ internal struct CustomHeaderEditView: View {

#Preview {
NavigationStack {
CustomHeaderEditView(backButtonVisible: true) {}
CustomHeaderEditView()
}
}
Loading

0 comments on commit 93ceb65

Please sign in to comment.