Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability use builtin observatories #75

Merged
merged 15 commits into from
Jan 18, 2024
Merged

feat: ability use builtin observatories #75

merged 15 commits into from
Jan 18, 2024

Conversation

steven-murray
Copy link
Contributor

Adds several default builtin observatories.

@steven-murray steven-murray requested a review from mkolopanis June 10, 2022 20:02
@steven-murray steven-murray self-assigned this Jun 10, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #75 (b18e66d) into main (0c6a344) will decrease coverage by 0.07%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   97.74%   97.66%   -0.08%     
==========================================
  Files          12       12              
  Lines         887      900      +13     
==========================================
+ Hits          867      879      +12     
- Misses         20       21       +1     
Impacted Files Coverage Δ
py21cmsense/observatory.py 96.13% <92.85%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c6a344...b18e66d. Read the comment docs.

@steven-murray steven-murray marked this pull request as ready for review June 10, 2022 20:48
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca6a483) 98.59% compared to head (aecb156) 98.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   98.59%   98.60%   +0.01%     
==========================================
  Files          15       15              
  Lines        1067     1076       +9     
==========================================
+ Hits         1052     1061       +9     
  Misses         15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@steven-murray steven-murray merged commit acfd76b into main Jan 18, 2024
21 checks passed
@steven-murray steven-murray deleted the profiles branch January 18, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants