Skip to content

Commit

Permalink
feat: include access to ska array postions via ska-ost-array-config p…
Browse files Browse the repository at this point in the history
…ackage
  • Loading branch information
DanielaBreitman committed Dec 16, 2024
1 parent 35d1e1c commit 3ff7c2b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/py21cmsense/observatory.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def from_ska(
cls,
subarray_type: str,
array_type: str = "low",
Trcv: tp.Temperature | Callable = 100 * un.K,
Trcv: tp.Temperature | Callable = 100 * un.K, # noqa N803
frequency: tp.Frequency | None = 150.0 * un.MHz,
**kwargs,
) -> Observatory:
Expand All @@ -252,7 +252,7 @@ def from_ska(
Other Parameters
----------------
All other parameters passed will be passed into the LowSubArray or MidSubArray class.
See the documentation of the ska-ost-array-config package for more information on these classes.
See the documentation of the ska-ost-array-config package for more information.
"""
try:
from ska_ost_array_config.array_config import LowSubArray, MidSubArray
Expand Down
5 changes: 3 additions & 2 deletions tests/test_observatory.py
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,9 @@ def test_from_ska():
exclude_stations="C1,C2",
)
low_custom = LowSubArray(
subarray_type="custom", custom_stations="C*,E1-*", exclude_stations="C1,C2"
) # selects all core stations and 6 stations in the E1 cluster and exclude core stations C1 and C2
subarray_type="custom",
custom_stations="C*,E1-*", exclude_stations="C1,C2"
) # selects all core stations, 6 stations in the E1 cluster, excludes core stations C1 and C2
assert obs.antpos.shape == low_custom.array_config.xyz.data.shape


Expand Down

0 comments on commit 3ff7c2b

Please sign in to comment.