-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CUDA dependency issues from PR #148. #150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @bdice .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Bradley! 🙏
Had some questions below
/merge |
Looks like there was a test failure on CI: FAILED python/ucxx/_lib/tests/test_server_client.py::test_server_client[thread-0-stream] - RuntimeError: Process did not exit cleanly (exit code: 1) |
Had to rerun to get it through, I'm still ironing out some of those tests that occasionally fail. |
Following up on an issue with
dependencies.yaml
from #148. See https://github.com/rapidsai/ucxx/pull/148/files#r1440832477.cc: @ajschmidt8 @pentschev