Separate out log level macros #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is the first step to addressing #10.
Add various style checks via pre-commit and run them in CI.
This PR adds conda packages (via rattler-build) and wheel builds of the C++ DSO.
This PR adds tests of the logger and runs them as part of the conda package build. To ensure correctness of both the code and the conda package itself, the tests are built and run both as part of the package build and in a subsequent test stage against the installed package. The wheel is currently untested since there is not an easy way to do that and we don't test C++ wheels anywhere else in RAPIDS currently. If we start doing that elsewhere we can port the approach to here.
vyasr
added
feature request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log levels are universal for all projects and are also usable in pure C code, so they can live in a standalone, nontemplated header.