Forward-merge branch-24.02 to branch-24.04 #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for an eps-neighborhood search based on random ball cover. The algorithm re-uses the existing rbc index creation. Changes: * add C++ API `raft::neighbors::ball_cover::epsUnexpL2NeighborhoodRbc` * lifted the 2/3-D limitation for eps-neighborhod via RBC (limitation still in place for k-nn queries) * pylibraft support for dense brute-force eps-neighborhood * pylibraft support for sparse/dense rbc epsneighborhood Note: The PR also contains a fix for the vertex degree computation in the brute force algorithm `spatial::knn::detail::epsUnexpL2SqNeighborhood`. Related to #1984 and #517 Authors: - Malte Förster (https://github.com/mfoerste4) - Tamas Bela Feher (https://github.com/tfeher) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Tamas Bela Feher (https://github.com/tfeher) - Corey J. Nolet (https://github.com/cjnolet) URL: #2028
|
SUCCESS - forward-merge complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to
branch-24.02that creates a PR to keepbranch-24.04up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.