Skip to content

Commit

Permalink
disallow fallback to Make in Python builds (#2563)
Browse files Browse the repository at this point in the history
Contributes to rapidsai/build-planning#146

Proposes:

* setting `[tool.scikit-build].ninja.make-fallback = false`, so `scikit-build-core` will not silently fallback to using GNU Make if `ninja` is not available
* including all groups in `dependencies.yaml` with `output_types: pyproject` in `output_types: requirements` as well.
  - *So that, for example, they show up in the solved environment in RAPIDS devcontainers (https://github.com/rapidsai/devcontainers)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #2563
  • Loading branch information
jameslamb authored Feb 3, 2025
1 parent 9927bdd commit 09fad06
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ dependencies:
- *libcusparse114
cuda_wheels:
specific:
- output_types: pyproject
- output_types: [pyproject, requirements]
matrices:
- matrix:
cuda: "12.*"
Expand Down Expand Up @@ -439,12 +439,12 @@ dependencies:
- python>=3.10,<3.13
run_pylibraft:
common:
- output_types: [conda, pyproject]
- output_types: [conda, pyproject, requirements]
packages:
- numpy>=1.23,<3.0a0
run_raft_dask:
common:
- output_types: [conda, pyproject]
- output_types: [conda, pyproject, requirements]
packages:
- dask-cuda==25.4.*,>=0.0.0a0
- rapids-dask-dependency==25.4.*,>=0.0.0a0
Expand Down
2 changes: 1 addition & 1 deletion python/libraft/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ build-dir = "build/{wheel_tag}"
cmake.build-type = "Release"
cmake.version = "CMakeLists.txt"
minimum-version = "build-system.requires"
ninja.make-fallback = true
ninja.make-fallback = false
sdist.reproducible = true
wheel.install-dir = "libraft"
wheel.packages = ["libraft"]
Expand Down
2 changes: 1 addition & 1 deletion python/pylibraft/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ build-dir = "build/{wheel_tag}"
cmake.build-type = "Release"
cmake.version = "CMakeLists.txt"
minimum-version = "build-system.requires"
ninja.make-fallback = true
ninja.make-fallback = false
sdist.exclude = ["*tests*"]
sdist.reproducible = true
wheel.packages = ["pylibraft"]
Expand Down
2 changes: 1 addition & 1 deletion python/raft-dask/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ build-dir = "build/{wheel_tag}"
cmake.build-type = "Release"
cmake.version = "CMakeLists.txt"
minimum-version = "build-system.requires"
ninja.make-fallback = true
ninja.make-fallback = false
sdist.exclude = ["*tests*"]
sdist.reproducible = true
wheel.packages = ["raft_dask"]
Expand Down

0 comments on commit 09fad06

Please sign in to comment.