Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to use rapids-conda-retry build and single-step environment solve. #580

Closed

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Feb 26, 2025

@bdice bdice requested a review from a team as a code owner February 26, 2025 17:26
Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 26, 2025 5:26pm

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for docs-rapids-ai ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f6156f3
🔍 Latest deploy log https://app.netlify.com/sites/docs-rapids-ai/deploys/67c1e08792e5950008642124
😎 Deploy Preview https://deploy-preview-580--docs-rapids-ai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor Author

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakirkham Could you review this?

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bradley! 🙏

Had a question below

# ...
rapids-dependency-file-generator \
--output conda \
--file-key "${FILE_KEY}" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to explain how this connects to the dependencies.yaml key?

Think the detail about this key including the packages produced in the previous build step would be interesting to readers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in f6156f3.

@bdice bdice requested a review from jakirkham February 28, 2025 17:15
@bdice
Copy link
Contributor Author

bdice commented Mar 3, 2025

#577 addressed these considerations in a different way. We can close this.

@bdice bdice closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants