Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix outdated RAPIDS versions #501

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

jameslamb
Copy link
Member

For a while now, we've had issues documenting the need to updated outdated references:

These have been open so long because I've been approaching them like "each example we update should be tested end-to-end", and I personally have found it difficult to find the time to do that very time-intensive testing.

In this PR, I'm proposing that we just update all the remaining references without manually testing them. Along the way here, I've also made changes to take better advantage of the automatic templating in this repo so that these are kept up to date with future RAPIDS releases.

Notes for Reviewers

Benefits of this:

  • avoids wasting users' time trying examples on very-old RAPIDS versions
  • nudges users toward newer versions of RAPIDS, CUDA, and Python (which should generally be better)

Why this is probably ok to do:

  • we have an easy mechanism for submitting feedback (Added Feedback Link to Sidebar #479)
  • it's unlikely that here in 2025, some of these examples using RAPIDS 23.x still work without any modification... these cloud services tend to change frequently!

How to Review This

To be absolutely clear: I did not test these changes. Opening this to get your opinions (@ncclementi @jacobtomlinson) on just updating these things anyway, and relying on later manual testing or user feedback to uncover issues.

@jameslamb jameslamb added breaking Introduces a breaking change improvement Improves an existing functionality labels Jan 24, 2025
@jameslamb jameslamb requested a review from a team as a code owner January 24, 2025 23:12
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with me, thanks @jameslamb. Like you say I think the feedback mechanism makes this less of an issue.

@jacobtomlinson jacobtomlinson merged commit fb37dd6 into rapidsai:main Jan 27, 2025
3 checks passed
@jameslamb jameslamb deleted the update-references branch January 27, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Introduces a breaking change improvement Improves an existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants